-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(anta.cli): Use configured anta inventory as output by default in get from-ansible #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to discuss about how to manage a change of the default inventory file This change is breaking CI in the second run |
titom73
force-pushed
the
fix/anta-ansible-cli
branch
from
November 20, 2023 12:54
d98a3db
to
37abc59
Compare
gmuloc
reviewed
Nov 21, 2023
mtache
requested changes
Nov 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use configured anta inventory if
--output
is not configured inanta get from-ansible
command.If destination file has content, then cli asks confirmation to user if he wants to overwrite:
anta get from-ansible --ansible-inventory ../anta-lab/atd-inventory/inventory.yml [19:07:19] INFO Building inventory from ansible file ../anta-lab/atd-inventory/inventory.yml Your destination file (anta-lab/network-tests/inventory.yml) is not empty, continue? [y/n]: n [19:07:27] CRITICAL conversion aborted since destination file is not empty
To run script in a non-interactive environment, you can use
--overwrite
to tell anta it can overwrite file with content.❯ anta get from-ansible --help Usage: anta get from-ansible [OPTIONS] Build ANTA inventory from an ansible inventory YAML file Options: -g, --ansible-group TEXT Ansible group to filter -i, --ansible-inventory FILE Path to your ansible inventory file to read -o, --output FILE Path to save inventory file. If not configured, use anta inventory file --overwrite Confirm script can overwrite existing inventory file [env var: ANTA_GET_FROM_ANSIBLE_OVERWRITE] --help Show this message and exit.
Checklist:
pre-commit run
)tox -e testenv
)