Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial streaming support. #89

Merged
merged 128 commits into from
Sep 28, 2022
Merged

Initial streaming support. #89

merged 128 commits into from
Sep 28, 2022

Conversation

benjaminrwilson
Copy link
Collaborator

@benjaminrwilson benjaminrwilson commented Aug 27, 2022

PR Summary

Testing

In order to ensure this PR works as intended, it is:

  • unit tested.
  • other or not applicable (additional detail/rationale required)

universal_pathlib is a drop-in replacement for pathlib. Our current unit tests should cover this thoroughly.

Compliance with Standards

As the author, I certify that this PR conforms to the following standards:

  • Code changes conform to PEP8 and docstrings conform to the Google Python style guide.
  • A well-written summary explains what was done and why it was done.
  • The PR is adequately tested and the testing details and links to external results are included.

@benjaminrwilson benjaminrwilson marked this pull request as ready for review September 22, 2022 20:28
@benjaminrwilson benjaminrwilson changed the title Feature/remote fs support Initial streaming support Sep 28, 2022
@benjaminrwilson benjaminrwilson changed the title Initial streaming support Initial streaming support. Sep 28, 2022
@benjaminrwilson benjaminrwilson merged commit 05b7b66 into main Sep 28, 2022
@benjaminrwilson benjaminrwilson deleted the feature/remote-fs-support branch September 28, 2022 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant