Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add readiness check to controller. Fixes #8283 #8285

Merged
merged 4 commits into from
Apr 13, 2022
Merged

fix: Add readiness check to controller. Fixes #8283 #8285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a11a53
fix: Add readiness check to controller. Fixes #8283
alexec Mar 31, 2022
8b620a9
fix: ok
alexec Apr 1, 2022
efb970f
Merge branch 'master' into readiness
alexec Apr 1, 2022
013fce2
Merge branch 'master' into readiness
alexec Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions manifests/base/workflow-controller/workflow-controller-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ spec:
selector:
matchLabels:
app: workflow-controller
strategy:
type: Recreate
template:
metadata:
labels:
Expand Down Expand Up @@ -35,10 +37,15 @@ spec:
ports:
- name: metrics
containerPort: 9090
- containerPort: 6060
- name: healthz
containerPort: 6060
readinessProbe:
httpGet:
port: metrics
path: /metrics
livenessProbe:
httpGet:
port: 6060
port: healthz
path: /healthz
# Require three failures to tolerate transient errors.
failureThreshold: 3
Expand Down
9 changes: 8 additions & 1 deletion manifests/install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1100,6 +1100,8 @@ spec:
selector:
matchLabels:
app: workflow-controller
strategy:
type: Recreate
template:
metadata:
labels:
Expand All @@ -1120,7 +1122,7 @@ spec:
failureThreshold: 3
httpGet:
path: /healthz
port: 6060
port: healthz
initialDelaySeconds: 90
periodSeconds: 60
timeoutSeconds: 30
Expand All @@ -1129,6 +1131,11 @@ spec:
- containerPort: 9090
name: metrics
- containerPort: 6060
name: healthz
readinessProbe:
httpGet:
path: /metrics
port: metrics
securityContext:
allowPrivilegeEscalation: false
capabilities:
Expand Down
9 changes: 8 additions & 1 deletion manifests/namespace-install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,6 +989,8 @@ spec:
selector:
matchLabels:
app: workflow-controller
strategy:
type: Recreate
template:
metadata:
labels:
Expand All @@ -1010,7 +1012,7 @@ spec:
failureThreshold: 3
httpGet:
path: /healthz
port: 6060
port: healthz
initialDelaySeconds: 90
periodSeconds: 60
timeoutSeconds: 30
Expand All @@ -1019,6 +1021,11 @@ spec:
- containerPort: 9090
name: metrics
- containerPort: 6060
name: healthz
readinessProbe:
httpGet:
path: /metrics
port: metrics
securityContext:
allowPrivilegeEscalation: false
capabilities:
Expand Down
9 changes: 8 additions & 1 deletion manifests/quick-start-minimal.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1401,6 +1401,8 @@ spec:
selector:
matchLabels:
app: workflow-controller
strategy:
type: Recreate
template:
metadata:
labels:
Expand All @@ -1422,7 +1424,7 @@ spec:
failureThreshold: 3
httpGet:
path: /healthz
port: 6060
port: healthz
initialDelaySeconds: 90
periodSeconds: 60
timeoutSeconds: 30
Expand All @@ -1431,6 +1433,11 @@ spec:
- containerPort: 9090
name: metrics
- containerPort: 6060
name: healthz
readinessProbe:
httpGet:
path: /metrics
port: metrics
securityContext:
allowPrivilegeEscalation: false
capabilities:
Expand Down
9 changes: 8 additions & 1 deletion manifests/quick-start-mysql.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1490,6 +1490,8 @@ spec:
selector:
matchLabels:
app: workflow-controller
strategy:
type: Recreate
template:
metadata:
labels:
Expand All @@ -1511,7 +1513,7 @@ spec:
failureThreshold: 3
httpGet:
path: /healthz
port: 6060
port: healthz
initialDelaySeconds: 90
periodSeconds: 60
timeoutSeconds: 30
Expand All @@ -1520,6 +1522,11 @@ spec:
- containerPort: 9090
name: metrics
- containerPort: 6060
name: healthz
readinessProbe:
httpGet:
path: /metrics
port: metrics
securityContext:
allowPrivilegeEscalation: false
capabilities:
Expand Down
9 changes: 8 additions & 1 deletion manifests/quick-start-postgres.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1482,6 +1482,8 @@ spec:
selector:
matchLabels:
app: workflow-controller
strategy:
type: Recreate
template:
metadata:
labels:
Expand All @@ -1503,7 +1505,7 @@ spec:
failureThreshold: 3
httpGet:
path: /healthz
port: 6060
port: healthz
initialDelaySeconds: 90
periodSeconds: 60
timeoutSeconds: 30
Expand All @@ -1512,6 +1514,11 @@ spec:
- containerPort: 9090
name: metrics
- containerPort: 6060
name: healthz
readinessProbe:
httpGet:
path: /metrics
port: metrics
securityContext:
allowPrivilegeEscalation: false
capabilities:
Expand Down