fix: Add readiness check to controller. Fixes #8283 #8285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Collins <[email protected]>
Signed-off-by: Alex Collins <[email protected]>
|
This can go in v3.3.2 |
sarabala1979
pushed a commit
that referenced
this pull request
Apr 18, 2022
Signed-off-by: Alex Collins <[email protected]>
alexec
added a commit
to alexec/argo-workflows
that referenced
this pull request
Apr 22, 2022
…rgoproj#8285)" This reverts commit 283f6b5. Signed-off-by: Alex Collins <[email protected]>
|
Should this be deployed everywhere or reverted? As I can see this PR still present just on the v3.3.2. |
It looks like this was reverted in #8454 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Collins [email protected]
Fixes #8283