Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: persist archived workflows with Persisted label (#11367) #11413

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

toyamagu-2021
Copy link
Member

@toyamagu-2021 toyamagu-2021 commented Jul 21, 2023

Signed-off-by: [email protected] [email protected]

Fixes #11367

Motivation

  • Label workflows as Persisted when persisted in DB.
  • Modify isArchivedWorkflow login in the frontend.

Modifications

  • Label workflow as Persisted when save to DB and retrieved from DB.

Verification

Submit workflow with ttl=10s

  1. Submit a workflow and labeled it as Archived
    image
  2. Workflow is gone
    image
  3. Refresh page then workflow and labeled as Persisted
    image
  4. Marked as Archived in the workflow list page
    image

Delete workflow in workflow list page

When checking both 'delete workflow?' and 'delete workflow in DB?'.

  • not archived -> successfully delete and gone from UI
  • Archived -> successfully delete and gone from UI
  • Persisted -> successfully delete and gone from UI

When checking 'delete workflow?' but not 'delete workflow in DB?'.

  • Archived -> successfully delete and exists in UI, then changed to Persisted.
  • Persisted -> successfully delete (actually do nothing) and exists in UI.

@toyamagu-2021 toyamagu-2021 changed the title fix: persist archived workflows with Persisted label fix: persist archived workflows with Persisted label (#11367) Jul 21, 2023
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@terrytangyuan terrytangyuan marked this pull request as ready for review July 21, 2023 14:54
@terrytangyuan terrytangyuan enabled auto-merge (squash) July 21, 2023 14:54
@terrytangyuan terrytangyuan merged commit 5b31ca1 into argoproj:master Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Pre-release] Workflows are shown as not archived after workflow GC
2 participants