Release v3.4.10 cherry-pick candidates

[terrytangyuan]

Please check the ones we want to cherry-pick.

From discussions:

• fix: Update config for metrics, throttler, and entrypoint. Fixes #11542, #11541 #11553
• fix: prevent stdout from disappearing in script templates. Fixes #11330 #11368
• fix: Upgraded docker distribution go package to v2.8.2 for fixing a high vulnerability #11554
• chore(deps): bump github.com/sirupsen/logrus from 1.9.2 to 1.9.3 #11200
• fix: always fail dag when shutdown is enabled. Fixes #11452 #11493
• fix(server): don't grab SAs if SSO RBAC is not enabled #11426

Bug fixes:

• 68b7ea6 fix: Upgrade hdfs and rpc module Upgrade rpc module to v2.0.3  #10030 (fix: Upgrade hdfs and rpc module #10030 #11543)
• 1709f96 fix: workflow-controller-configmap/parallelism setting not working in… (fix: properly init throttler in 3.4.9+ #11546)
• 6e50cb0 fix: Switch to use kong/httpbin to support arm64. Fixes Replace httpbin with something up to date #10427 (fix: Switch to use kong/httpbin to support arm64. Fixes #10427 #11533)
• b2e2106 fix: Added vulnerability fixes for gorestlful gopkg & OS vulnerabilities in golang:1.20-alpine3.16 (fix: Added vulnerability fixes for gorestlful gopkg & OS vulnerabilities in golang:1.20-alpine3.16 #11538)
• 4a3cb0e fix: Flaky test about lifecycle hooks (fix: Flakey test about lifecycle hooks #11534)
• 143d0f5 fix: Fixed memoization is unchecked after mutex synchronization. Fixes Mutex check happens after memoization cache check and lock info missing from UI #11219 (fix: Fixed memoization is unchecked after mutex synchronization. Fixes #11219 #11456)
• 545bf38 fix: Ensure target Workflow hooks not nil (Getting Error: assignment to entry in nil map when hooks are used #11521) (fix: Ensure target Workflow hooks not nil (#11521) #11535)
• 9c77247 fix: azure hasLocation incorporates endpoint. Fixes inconsistent hasLocation between S3 and Azure artifacts #11512 (fix: azure hasLocation incorporates endpoint. Fixes #11512 #11513)
• b26f5b8 fix: Support OOMKilled with container-set. Fixes Pod hangs when container in ContainerSet is OOM Killed #10063 (fix: Support OOMKilled with container-set. Fixes #10063 #11484)
• cb1713d fix: valueFrom in template parameter should be overridable. Fixes 10182 (fix: valueFrom in template parameter should be overridable. Fixes 10182 #10281)
• 61a4ac4 fix: Ignore failed read of exit code. Fixes Error (exit code 64): failed to read exit-code of dependency  #11490 (fix: Ignore failed read of exit code. Fixes #11490 #11496)
• f6c6dd7 fix: Fixed UI workflowDrawer information link broken. Fixes UI: workflowDrawer's information link is not correctly working #11494 (fix: Fixed UI workflowDrawer information link broken. Fixes #11494 #11495)
• 1f6b19f fix: add guard against NodeStatus. Fixes Default initialised NodeStatus causes random false failures.  #11102 (fix: add guard against NodeStatus. Fixes #11102 #11451)
• ce9e50c fix: Datepicker Style Malfunction Issue. Fixes UI: Datepicker Style Malfunction Issue #11476 (fix: Datepicker Style Malfunction Issue. Fixes #11476 #11480)
• f8a34a3 fix: Devcontainer resets /etc/hosts (The container created by Devcontainer keeps resetting /etc/hosts #11439) (fix: Devcontainer resets /etc/hosts (#11439) #11440)
• 7310e9c fix: UI toolbar sticky (fix: UI toolbar sticky #11444)
• c6a2a4f fix: Apply the creator labels about the user who resubmitted a Workflow (fix: Apply the creator labels about the user who resubmitted a Workflow #11415)
• f5d41f8 fix: make archived logs more human friendly in UI (fix: make archived logs more human friendly in UI #11420)
• 5cb75d9 fix: add query string to workflow detail page(3.5 Pre-release: UI crashes when thare are archived workflows which has same name and namespace. #11371) (fix(ui): add query string to workflow detail page. Fixes #11371 #11373)
• 5b31ca1 fix: persist archived workflows with Persisted label ([Pre-release] Workflows are shown as not archived after workflow GC #11367) (fix: persist archived workflows with Persisted label (#11367) #11413)
• 97b6fa8 fix: Modify broken ui by archived col (fix: Modify broken ui by archived col #11366)
• fdb3ec0 fix: Live workflow takes precedence during merge to correctly display in the UI (fix: Live workflow takes precedence during merge to correctly display in the UI #11336)
• 137d5f8 fix(controller): Enable dummy metrics server on non-leader workflow controller (fix(controller): Enable dummy metrics server on non-leader workflow controller #11295)
• 6f1cb48 fix(windows): Propagate correct numerical exitCode under Windows (Fixes Exit Code on Windows not correct #11271) (fix(windows): Propagate correct numerical exitCode under Windows (Fixes #11271) #11276)
• ac9161c fix: Workflow list page crashes for workflow rows without labels (fix: Workflow list page crashes for workflow rows without labels #11195)
• 2016078 fix: add space to fix release action issue (fix: add space to fix release action issue #11160)
• 48097ea fix(controller): Drop Checking daemoned children without nodeID (Fixes there's no nodeID in msg="Checking daemoned children of " #10960) (fix(controller): Drop log "Checking daemoned children" without nodeID (Fixes #10960) #10974)

Build:

• d876464 build: upgrade to use nodev20 (build: upgrade to use nodev20 #11410)
• 589a4b7 build: pin versions of NPM global deps in Makefile (build: pin versions of NPM global deps in Makefile #11425)
• ce87d74 build: Remove personal token for docs publishing (build: Remove personal token for docs publishing #11345)
• bf6ce03 build: use only relevant files in build (build: use only relevant files in build #11189)
• ba82fd8 build: devcontainer improvements and documentation (build: devcontainer improvements and documentation #11162)

CI:

• 2d20532 ci: fix snyk.yaml and release.yaml for Node v20 (ci: fix snyk.yaml and release.yaml for Node v20 #11461)
• 6905cf3 ci: Bump E2E_WAIT_TIMEOUT to avoid E2E test failures in CI (ci: Bump E2E_WAIT_TIMEOUT to avoid E2E test failures in CI #11392)
• c17fb81 ci: Grant write permission to docs workflow (ci: Grant write permission to docs workflow #11348)
• a1fc404 ci: Switch to use “with” in gh-pages.yaml (ci: Switch to use “with” in gh-pages.yaml  #11347)
• 1e0bb42 ci: Fix broken codgen build (ci: Fix broken codgen build #11311)
• 9deb51f ci: Disable flaky link check (ci: Disable flaky link check #11305)
• 539a51e ci: add PR title conventional commits checker (ci: add PR title conventional commits checker #10981)

[agilgur5]

Would want to get a fix in for #11542 (et al) to make sure that all regressions resulting from #11178 are resolved

[ajoskowski]

We would like to get a fix for #11330 because it breaks our production pipelines.

[terrytangyuan]

Would want to get a fix in for #11542 (et al) to make sure that all regressions resulting from #11178 are resolved

#11553

[terrytangyuan]

We would like to get a fix for #11330 because it breaks our production pipelines.

Just merged #11368. Will include it in this release.

[caelan-io]

Let's get this one in the patch release as well: #11493

[advithVashist]

Would it be possible to get this fix in? #10927

[terrytangyuan]

Would it be possible to get this fix in? #10927

@advithVashist That's a feature so no. We want to avoid new bugs.

[advithVashist]

Would it be possible to get this fix in? #10927

@advithVashist That's a feature so no. We want to avoid new bugs.

Got it, thanks :)

[jaen]

Any chance of getting #11456 in? Would be nice to not have to manually patch this and I'm not sure if the check box being unchecked mean it's not getting in.

[terrytangyuan]

Sure

[terrytangyuan]

Working branch: https://github.com/argoproj/argo-workflows/tree/release-3.4.10

Will need more time for the following:

Failed to cherry-pick due to conflicts:

• 68b7ea6 fix: Upgrade hdfs and rpc module
• 143d0f5 fix: Fixed memoization is unchecked after mutex synchronization.
• 61a4ac4 fix: Ignore failed read of exit code.
• b26f5b8 fix: Support OOMKilled with container-set.
• 1f6b19f fix: add guard against NodeStatus.
• 105031b fix: always fail dag when shutdown is enabled.

[terrytangyuan]

I'm not sure if the check box being unchecked mean it's not getting in.

Yes unchecked ones are not getting included in this release. They are either not cherry-pickable or are bug fixes for new features that did not exist in v3.4 yet.

[terrytangyuan]

These cannot be cherry-picked since the v3.4.10 release branch diverges from master branch too much and have non-trivial conflicts to resolve. If you'd like to get them into this release, please submit a PR to the release branch by the end of next Tuesday. https://github.com/argoproj/argo-workflows/tree/release-3.4.10

• 143d0f5 fix: Fixed memoization is unchecked after mutex synchronization. @shmruin @jaen
• 61a4ac4 fix: Ignore failed read of exit code. @alexec
• b26f5b8 fix: Support OOMKilled with container-set. @alexec
• 1f6b19f fix: add guard against NodeStatus. @isubasinghe
• 105031b fix: always fail dag when shutdown is enabled. @isubasinghe

[agilgur5]

#11426 might be good to get into a patch as well. I believe it's still failing on a test flake (unfortunately being a Member does not give CI retry permissions 😕 )

[jaen]

@shmruin would you be willing to make a PR for this? The conflict seems rather simple to solve as far as I can tell (add , nil and revert the use of Set):
jaen@cbcb5a3

Sorry for asking, but I don't have a good way to test this right now.

[shmruin]

@jaen yes, I am willing to. I think I can try this on tuesday.

[terrytangyuan]

#11426 might be good to get into a patch as well. I believe it's still failing on a test flake (unfortunately being a Member does not give CI retry permissions 😕 )

Done

[shmruin]

@terrytangyuan @jaen I made a PR to realease-3.4.10 to apply the thing below as you mentioned. you can see in #11578. I tested in UI and with code again, but if there's any problem, please tell me. thanks.

143d0f5 fix: Fixed memoization is unchecked after mutex synchronization.

[terrytangyuan]

Thanks. Since no one else has responded regarding other commits, I'll trigger the release process soon.

[terrytangyuan]

Tagged https://github.com/argoproj/argo-workflows/releases/tag/v3.4.10