fix: Argo DB init conflict when deploy workflow-controller with multiple replicas #11177 #11178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astraw99
changed the title
Signed-off-by: astraw99 <[email protected]>
astraw99
force-pushed
the
fix-initdb-conflict
branch
from
81cec02
to
776db1f
Compare
terrytangyuan
approved these changes
Jul 1, 2023
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jul 4, 2023
…ple replicas argoproj#11177 (argoproj#11178) Signed-off-by: astraw99 <[email protected]>
61 tasks
terrytangyuan
pushed a commit
that referenced
this pull request
Jul 19, 2023
…ple replicas #11177 (#11178) Signed-off-by: astraw99 <[email protected]>
This was referenced Aug 9, 2023
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
…ple replicas argoproj#11177 (argoproj#11178) Signed-off-by: astraw99 <[email protected]> Signed-off-by: Dillen Padhiar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11177
Motivation
Fix Argo DB init conflict when deploy workflow-controller with multiple replicas.
Modifications
Move the DB init logic to after the leader election completed.
Verification
After the code modification, tested the workflow-controller deployment in my environment with
multiple replicas (3 and 5), both work ok.