Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Azure input artifact support optional. Fixes #11179 #11235

Merged
merged 2 commits into from
Jul 1, 2023
Merged

fix: Azure input artifact support optional. Fixes #11179 #11235

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97c928d
Azure input artifact support optional
liangyuanpeng Jun 20, 2023
0a58d4d
Merge branch 'master' into artifact_azure_optional
terrytangyuan Jul 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions workflow/artifacts/azure/azure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,9 @@ func (azblobDriver *ArtifactDriver) Load(artifact *wfv1.Artifact, path string) e
return fmt.Errorf("unable to determine if %s is a directory: %s", artifact.Azure.Blob, err)
}

// It's not a directory and the file doesn't exist, so return the original BlobNotFound error.
// It's not a directory and the file doesn't exist, Return the original NoSuchKey error.
if !isDir && !isEmptyFile {
return fmt.Errorf("unable to download blob %s: %s", artifact.Azure.Blob, origErr)
return argoerrors.New(argoerrors.CodeNotFound, origErr.Error())
}

// When we tried to download the blob as a file, we created an empty file for the
Expand Down