Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Azure input artifact support optional. Fixes #11179 #11235

Merged

Conversation

liangyuanpeng
Copy link
Contributor

Fixes #11179

Motivation

Modifications

Return argoerrors.CodeNotFound when the artifact is not a directory and the file doesn't exist

Verification

Create a workflow to download azure artifact and the blob is not exist.

When optional is true, workflow is green.

test-azure-artifact.yaml

apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: s3-azure-artifact-
spec:
  entrypoint: main
  templates:
  - dag:
      tasks:
      - name: generate
        template: generate
      - depends: generate
        name: consume
        template: consume
    name: main
  - container:
      args:
      - ls
      command:
      - bash
      - -c
      image: argoproj/argosay:v2
    name: generate
  - container:
      args:
      - ls /tmp
      command:
      - bash
      - -c
      image: argoproj/argosay:v2
    inputs:
      artifacts:
      - archive:
          none: {}
        azure:
          blob: file2.txt
          accountKeySecret:
            name: azure-storage-credentials
            key: account-access-key
          container: argo
          endpoint: https://{yourself}.blob.core.windows.net
        name: file
        optional: true
        path: /tmp/file.txt
    name: consume

@terrytangyuan terrytangyuan enabled auto-merge (squash) June 20, 2023 10:07
@terrytangyuan terrytangyuan merged commit 609539d into argoproj:master Jul 1, 2023
JPZ13 pushed a commit to pipekit/argo-workflows that referenced this pull request Jul 4, 2023
terrytangyuan pushed a commit that referenced this pull request Jul 19, 2023
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optional property does not work with azure artifacts
2 participants