fix: Set Canary Strategy default maxUnavailable to 25%

[khhirani]

Closes #938

Signed-off-by: khhirani [email protected]

[codecov-io]

Codecov Report

Merging #981 (0d0ee20) into master (7384684) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #981   +/-   ##
=======================================
  Coverage   81.36%   81.36%           
=======================================
  Files         100      100           
  Lines        8844     8844           
=======================================
  Hits         7196     7196           
  Misses       1180     1180           
  Partials      468      468           

Impacted Files	Coverage Δ
utils/defaults/defaults.go	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7384684...0d0ee20. Read the comment docs.

[jessesuen]

Looks good. Can you update both the documentation and the types.go to reflect this?

[jessesuen]

Do you know why this is 25 and not 25%. Can you verify that we aren't defaulting max unavailable to 25 pods instead of 25% of pods?

[khhirani]

The code which resolves both MaxSurge and MaxUnavailable uses the method intstrutil.GetValueFromIntOrPercent. I confirmed that it works with some manual tests.

[jessesuen]

OK, thanks for confirming. I see that GetValueFromIntOrPercent interprets all string values as percentages and not integer values, even if the value is missing a % character:

func GetValueFromIntOrPercent(intOrPercent *IntOrString, total int, roundUp bool) (int, error) {
	if intOrPercent == nil {
		return 0, errors.New("nil value for IntOrString")
	}
	value, isPercent, err := getIntOrPercentValue(intOrPercent)
	if err != nil {
		return 0, fmt.Errorf("invalid value for IntOrString: %v", err)
	}
	if isPercent {
		if roundUp {
			value = int(math.Ceil(float64(value) * (float64(total)) / 100))
		} else {
			value = int(math.Floor(float64(value) * (float64(total)) / 100))
		}
	}
	return value, nil
}

func getIntOrPercentValue(intOrStr *IntOrString) (int, bool, error) {
	switch intOrStr.Type {
	case Int:
		return intOrStr.IntValue(), false, nil
	case String:
		s := strings.Replace(intOrStr.StrVal, "%", "", -1)
		v, err := strconv.Atoi(s)
		if err != nil {
			return 0, false, fmt.Errorf("invalid value %q: %v", intOrStr.StrVal, err)
		}
		return int(v), true, nil
	}
	return 0, false, fmt.Errorf("invalid type: neither int nor percentage")
}

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication