Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canary strategy is not defaulting maxUnavailable to 25% #938

Closed
jessesuen opened this issue Jan 12, 2021 · 1 comment · Fixed by #981
Closed

Canary strategy is not defaulting maxUnavailable to 25% #938

jessesuen opened this issue Jan 12, 2021 · 1 comment · Fixed by #981
Assignees
@khhirani
Labels
bug Something isn't working
Milestone
v1.0

Comments

@jessesuen
Copy link
Member

jessesuen commented Jan 12, 2021 •
edited
Loading

Summary

The canary strategy is supposed to behave like a Deployment rollingUpdate strategy by defaulting both maxUnavailable and maxSurge to 25%.

While maxSurge does seem to be defaulting to 25%, maxUnavailable appears to be defaulting to 0.

Diagnostics

What version of Argo Rollouts are you running?

v0.10.2 but I tested with v0.8.2 and v0.6.3 those versions also exhibit the same behavior.

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.
@jessesuen jessesuen added the bug Something isn't working label Jan 12, 2021
@jessesuen jessesuen added this to the v1.0 milestone Jan 12, 2021
@jessesuen
Copy link
Member Author

@dthomson25 helped me pinpoint the bug to here:

c8d7de4#diff-460e0448455cae92ce052a3a2d029eb1e38a2c1d9c29c994e5128cae2a7e44c9R17

@jessesuen jessesuen mentioned this issue Jan 12, 2021
Merged
@khhirani khhirani self-assigned this Feb 5, 2021
@khhirani khhirani mentioned this issue Feb 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khhirani khhirani

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

fix: Set Canary Strategy default maxUnavailable to 25% khhirani/argo-rollouts
2 participants
@jessesuen @khhirani