feat: Add ability to restart maxUnavailable pods to BlueGreen strategy #937
Conversation
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
khhirani
force-pushed
the
bluegreen-maxunavailable
branch
from
c169f95 to
0e5f490
Compare
Codecov Report
@@ Coverage Diff @@
## master #937 +/- ##
==========================================
- Coverage 81.60% 81.59% -0.01%
==========================================
Files 99 99
Lines 8732 8739 +7
==========================================
+ Hits 7126 7131 +5
- Misses 1151 1152 +1
- Partials 455 456 +1
Continue to review full report at Codecov.
|
khhirani
changed the title
| // Value can be an absolute number (ex: 5) or a percentage of total pods at the start of update (ex: 10%). | ||
| // Absolute number is calculated from percentage by rounding down. | ||
| // This can not be 0 if MaxSurge is 0. | ||
| // By default, a fixed value of 1 is used. |
There was a problem hiding this comment.
We need to figure out what the real default is (what kubernetes chooses). I originally thought it was 20%, then yesterday I thought it was 0, and now I see this comment (which you copied from canary) stating it's 1. But now I'm reading documentation says it's 25%:
https://kubernetes.io/docs/concepts/workloads/controllers/deployment/
There was a problem hiding this comment.
The answer is:
- extensions/Deployment defaults it to 1
- apps/Deployment defaults it to 25%
- argoproj.io/Rollout defaults to 0, which is a bug and should be 25%. Canary strategy is not defaulting maxUnavailable to 25% #938 is tracking that bug.
…to bluegreen-maxunavailable
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
…i/argo-rollouts into bluegreen-maxunavailable
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
Signed-off-by: khhirani <[email protected]>
…i/argo-rollouts into bluegreen-maxunavailable
Signed-off-by: khhirani <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Closes #866
Signed-off-by: khhirani [email protected]