Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #71 - Add back service informer to handle Service recreations quicker #95

Merged
merged 1 commit into from
Jun 3, 2019

Conversation

alexmt
Copy link
Contributor

@alexmt alexmt commented Jun 1, 2019

Closes #71
Closes #83

@alexmt alexmt requested review from dthomson25 and jessesuen June 1, 2019 21:02
@codecov-io
Copy link

codecov-io commented Jun 1, 2019

Codecov Report

Merging #95 into master will decrease coverage by 0.19%.
The diff coverage is 63.95%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #95     +/-   ##
=========================================
- Coverage   79.02%   78.82%   -0.2%     
=========================================
  Files          15       15             
  Lines        1721     1790     +69     
=========================================
+ Hits         1360     1411     +51     
- Misses        267      280     +13     
- Partials       94       99      +5
Impacted Files Coverage Δ
utils/log/log.go 100% <ø> (ø) ⬆️
controller/controller.go 52.35% <45.94%> (+1.31%) ⬆️
controller/service.go 86.33% <77.55%> (-4.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6aa76d...f764f45. Read the comment docs.

@alexmt alexmt force-pushed the 71-service-informer branch from 14f580a to f764f45 Compare June 1, 2019 21:33
Copy link
Member

@dthomson25 dthomson25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants