Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollout don't remove rollouts-pod-template-hash service selector after switching from blue-green to canary strategy #83

Closed
alexmt opened this issue May 21, 2019 · 0 comments · Fixed by #95
Assignees
Labels
bug Something isn't working
Milestone

Comments

@alexmt
Copy link
Contributor

alexmt commented May 21, 2019

Rollout don't remove rollouts-pod-template-hash service selector after switching from blue-green to canary strategy.

Steps to reproduce:

  1. Deploy rollout with using blue-green strategy
  2. Change strategy to canary and update rollout image
  3. Rollout deploys canary version as expected but service don't route any traffic to it because it still has rollouts-pod-template-hash service selector which was set during blue-green deployment.

Expected behavior:

Rollout should ensure that rollouts-pod-template-hash service selector is removed unless strategy is blue-green

Version: v0.3.1

@jessesuen jessesuen added this to the v0.3.1 milestone May 22, 2019
@jessesuen jessesuen added the bug Something isn't working label May 31, 2019
@alexmt alexmt self-assigned this May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants