Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Available Condition #60

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Improve Available Condition #60

merged 1 commit into from
Apr 25, 2019

Conversation

dthomson25
Copy link
Member

@dthomson25 dthomson25 commented Apr 25, 2019

Make available condition more clear for BlueGreen and Canary.

A BlueGreen rollout is available when the replicaset that is receiving traffic from the active selector has the min availability of pods.

A Canary Rollout is available when the sum of available pods from all replicasets is greater than or equal to the rollout's replica count.

Note: Before this PR, the HPA selector in the status wasn't being updated when the activeSelector was switched. That was okay previously because the controller would have enqueued the rollout again and change the HPA selector on the second reconciliation. Part of this implementation includes the selector change in the first reconciliation.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@ce5920c). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #60   +/-   ##
=========================================
  Coverage          ?   78.27%           
=========================================
  Files             ?       14           
  Lines             ?     1625           
  Branches          ?        0           
=========================================
  Hits              ?     1272           
  Misses            ?      266           
  Partials          ?       87
Impacted Files Coverage Δ
controller/service.go 84.88% <ø> (ø)
utils/conditions/conditions.go 89.11% <ø> (ø)
controller/bluegreen.go 81.33% <100%> (ø)
controller/sync.go 74.08% <100%> (ø)
utils/replicaset/replicaset.go 94.3% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce5920c...1aaa8f3. Read the comment docs.

Copy link
Contributor

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dthomson25 dthomson25 merged commit 4b59abf into master Apr 25, 2019
@dthomson25 dthomson25 deleted the available branch April 25, 2019 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants