Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Rollout Conditions #41

Closed
dthomson25 opened this issue Mar 16, 2019 · 2 comments
Closed

Rework Rollout Conditions #41

dthomson25 opened this issue Mar 16, 2019 · 2 comments
Milestone

Comments

@dthomson25
Copy link
Member

dthomson25 commented Mar 16, 2019

Currently, there are invalidSpec and available conditions. The invalidSpec condition highlights invalid yaml, but the available condition needs to be fleshed out more. The available condition is not used for the Canary strategy and its use in the BlueGreen strategy does not indicate the status of a rollout well. Instead, the condition indicates that the active service is pointing at a replicaset and that replicaset is at the desired number of replicas. As a result, the rollout could have an available condition set to true while the controller is still working on the rollout.

With the work required to rework the available condition, we will need to make sure that we are able to answer the following questions. What does it mean for a rollout to be available? Does that mean the rollout is in a steady-state? Does that mean the rollout is serving traffic to prod?

@dthomson25 dthomson25 added this to the v0.4.0 milestone Mar 16, 2019
@dthomson25 dthomson25 modified the milestones: v0.4.0, v0.3.0 Mar 27, 2019
@dthomson25
Copy link
Member Author

The Progressing condition was introduced with the implementing ProgessDeadlineSeconds PR (#54) to indicates that a rollout is in a steady-state. The #60 PR improves the available condition to make it more clear when a Rollout is available.

@dthomson25
Copy link
Member Author

Closing with #60 and #54 as the fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant