Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove service informer #45

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Remove service informer #45

merged 2 commits into from
Mar 25, 2019

Conversation

dthomson25
Copy link
Member

No description provided.

@dthomson25 dthomson25 changed the title Remove svc informer Remove service informer Mar 25, 2019
@dthomson25
Copy link
Member Author

dthomson25 commented Mar 25, 2019

Address issues #18 by removing the Service informer and #17 by removing a call to the API server instead of the informer

@codecov-io
Copy link

codecov-io commented Mar 25, 2019

Codecov Report

Merging #45 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   75.62%   75.64%   +0.01%     
==========================================
  Files          13       13              
  Lines        1358     1322      -36     
==========================================
- Hits         1027     1000      -27     
+ Misses        248      242       -6     
+ Partials       83       80       -3
Impacted Files Coverage Δ
controller/controller.go 46.29% <ø> (-2.23%) ⬇️
controller/service.go 84.21% <ø> (+3.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eacd31...70426ca. Read the comment docs.

@dthomson25 dthomson25 merged commit 3d40c3f into master Mar 25, 2019
@dthomson25 dthomson25 deleted the remove-svc-informer branch March 25, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants