We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In service.go:
func (c *Controller) getRolloutsForService(service *corev1.Service) ([]*v1alpha1.Rollout, error) { allROs, err := c.rolloutsclientset.ArgoprojV1alpha1().Rollouts(service.Namespace).List(metav1.ListOptions{}) if err != nil { return nil, err }
We should use the informer instead of list API
The text was updated successfully, but these errors were encountered:
With this issue, we should investigate the code base and find other places that we can switch to informers in addition to the above example
Sorry, something went wrong.
After investigating the code, the only place we use the API instead of the rollout informer is at https://github.com/argoproj/argo-rollouts/blob/master/controller/replicaset.go#L35. In this case, we are required to use the API to get up to date information.
No branches or pull requests
In service.go:
We should use the informer instead of list API
The text was updated successfully, but these errors were encountered: