fix(analysis): Take RollbackWindow into account when Reconciling Analysis Runs. Fixes #3669

[Psukhe]

This PR should fix an issue with Background (and other) Analysis runs from running when rolling back to a revision within a Rollback Window. I'm not incredibly well versed with how testing is done within this project or golang in general, so any assistance in that area would be appreciated. That being said I did give it a best effort.

I originally discovered the issue described in #3669 in v1.6.6, where by rolling back an application within a rollback window unexpectedly ran a background analysis which could fail, causing a rapid scale up and down of the application's replicaset. To reconcile that issue the failed background analysis run needed to be deleted. I am unable to easily reproduce that issue, but considering that we didn't expect any background analysis to run when rolling back to a revision within a rollback window, this PR should address that issue.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I've signed my commits with DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My builds are green. Try syncing with master if they are not.
• My organization is added to USERS.md.

[github-actions]

Go Published Test Results

2 164 tests   2 164 ✅  2m 54s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit 2ed5b66.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.25%. Comparing base (4f1edbe) to head (2ed5b66).
Report is 81 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3670      +/-   ##
==========================================
- Coverage   80.27%   80.25%   -0.02%     
==========================================
  Files         156      156              
  Lines       17964    17965       +1     
==========================================
- Hits        14420    14418       -2     
- Misses       2631     2634       +3     
  Partials      913      913              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

E2E Tests Published Test Results

  4 files    4 suites   3h 23m 48s ⏱️
111 tests  98 ✅  6 💤 7 ❌
452 runs  420 ✅ 24 💤 8 ❌

For more details on these failures, see this check.

Results for commit 2ed5b66.