Background Analysis runs when rolling back to a revision within defined Rollback Window

[Psukhe]

Checklist:

• I've included steps to reproduce the bug.
• I've included the version of argo rollouts.

Describe the bug

Background Analysis runs when rolling back to a revision within defined Rollback Window

To Reproduce

Files to reproduce are present here: https://github.com/Psukhe/background-analysis-runs-when-within-rollback-window/tree/main

• kubectl apply -f analysis-template.yml
• kubectl apply -f rollout-with-background-analysis-and-rollback-window-step-1.yml
• kubectl apply -f rollout-with-background-analysis-and-rollback-window-step-2.yml
• kubectl argo rollouts undo rollout-with-background-analysis-and-rollback-window

Expected behavior

I would expect no Analysis Runs when rolling back within a defined Rollback Window

Version

v1.7.1+6a99ea9

Logs

time="2024-06-25T20:52:29Z" level=info msg="Rollback within the window: 0 (3)" namespace=default rollout=rollout-with-background-analysis-and-rollback-window
...
time="2024-06-25T20:52:29Z" level=info msg="Background Analysis Run 'rollout-with-background-analysis-and-rollback-window-cd6c94ffd-3' Status New: 'Running' Previous: ''" event_reason=AnalysisRunRunning namespace=default rollout=rollout-with-background-analysis-and-rollback-window

All logs are present here: https://github.com/Psukhe/background-analysis-runs-when-within-rollback-window/tree/main

---

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.