fix(controller): Add klog logrus bridge. Fixes #2707. #2701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sineaggi
force-pushed
the
klog-logrus-bridge
branch
from
fa877ca to
a885b90
Compare
|
Should fix the issue mentioned in #1914
|
Sineaggi
force-pushed
the
klog-logrus-bridge
branch
from
a885b90 to
09b1452
Compare
Sineaggi
force-pushed
the
klog-logrus-bridge
branch
from
09b1452 to
61fd3c1
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2701 +/- ##
=======================================
Coverage 81.47% 81.47%
=======================================
Files 133 133
Lines 20152 20154 +2
=======================================
+ Hits 16419 16421 +2
Misses 2881 2881
Partials 852 852
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Clayton Walker <[email protected]>
Signed-off-by: Clayton Walker <[email protected]>
Sineaggi
force-pushed
the
klog-logrus-bridge
branch
from
960ea46 to
3d11f83
Compare
Sineaggi
changed the title
Sineaggi
changed the title
zachaller
reviewed
Apr 10, 2023
Sineaggi
force-pushed
the
klog-logrus-bridge
branch
from
2cc76db to
1db4de5
Compare
Signed-off-by: Clayton Walker <[email protected]>
Sineaggi
force-pushed
the
klog-logrus-bridge
branch
2 times, most recently
from
3676610 to
fbb5643
Compare
Signed-off-by: Clayton Walker <[email protected]>
Sineaggi
force-pushed
the
klog-logrus-bridge
branch
from
fbb5643 to
ad481b9
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
zachaller
approved these changes
Apr 11, 2023
|
@zachaller thanks for the review. Are there any next steps for me? |
|
@Sineaggi Merged, Thanks for contributing! |
zachaller
pushed a commit
that referenced
this pull request
May 5, 2023
* Add klog logrus bridge Signed-off-by: Clayton Walker <[email protected]> * Pull klog bridge out to log util Signed-off-by: Clayton Walker <[email protected]> * Upgrade logrusr to v4 Signed-off-by: Clayton Walker <[email protected]> * Simplify logging Signed-off-by: Clayton Walker <[email protected]> --------- Signed-off-by: Clayton Walker <[email protected]>
zachaller
added
the
cherry-pick-completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2707
closes: #1914
Checklist:
"fix(controller): Updates such and such. Fixes #1234".