JSON Logging

[DWSR]

Summary

Argo Rollouts is one of the few Argo projects that doesn't support JSON logging

Use Cases

When trying to naively parse logs using a log aggregator like Fluentd.

---

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

[hcelaloner]

I am not sure since I didn't use it. However, it seems that the controller provides flags to change log format: https://github.com/argoproj/argo-rollouts/blob/master/cmd/rollouts-controller/main.go#L221

Therefore, I don't know whether it is documented or not but passing additional command-line arguments to the rollouts-controller may change its log format.

[perenesenko]

@DWSR
yes, that's correct --logformat=json will work.
We just need to fix a documentation

[hcelaloner]

Hi @perenesenko if you do not have any different plans for this one, I can submit a PR similar to ArgoCD server command docs as follows: hcelaloner@67d3900 (may also move this new section to the end of installation.md, if that would be more appropriate?)

Edit: Submitted a PR may work on it or change it based on comments 👍

[AliDotS]

When leader election is enabled there is one line that doesn't follow JSON format.
12:08:56.641662 1 leaderelection.go:248] attempting to acquire leader lease argocd/argo-rollouts-controller-lock...

[github-actions]

This issue is stale because it has been open 60 days with no activity.

[DWSR]

Not stale.

[github-actions]

This issue is stale because it has been open 60 days with no activity.

[Sineaggi]

Not stale.

[github-actions]

This issue is stale because it has been open 60 days with no activity.

[DWSR]

Not stale.

[Sineaggi]

@AliDotS presumably logs from klog aren't being mapped to logrus.