feat: ArgoRollouts dashboard now supporting rootpath #2075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r code: PROTOCOL_ERROR' Signed-off-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: “schakradari” <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2075 +/- ##
=======================================
Coverage 82.43% 82.43%
=======================================
Files 120 120
Lines 17440 17440
=======================================
Hits 14376 14376
Misses 2352 2352
Partials 712 712 Continue to review full report at Codecov.
|
harikrongali
reviewed
Jun 4, 2022
|
lgtm apart from above comment |
Signed-off-by: “schakradari” <[email protected]>
Signed-off-by: “schakradari” <[email protected]>
harikrongali
approved these changes
Jun 4, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
jenciso
pushed a commit
to jenciso/argo-rollouts
that referenced
this pull request
Oct 25, 2022
* fix: add workaround to fix 'stream terminated by RST_STREAM with error code: PROTOCOL_ERROR' Signed-off-by: Alexander Matyushentsev <[email protected]> * ArgoRollouts dashboard should support rootpath Signed-off-by: “schakradari” <[email protected]> * fixed camelCase naming Signed-off-by: “schakradari” <[email protected]> * fixed Lint error Signed-off-by: “schakradari” <[email protected]> Co-authored-by: Alexander Matyushentsev <[email protected]> Co-authored-by: Remington Breeze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".Before
The dashboard was always shown on localhost:3100/rollouts
After
Added the option rootpath in the dashboard controller
The dashbaord is shown on localhost:3100/{rootpath}
when the rootpath is not specified, it takes the value rollouts as the rootpath
The default value of rootpath is "rollouts"