Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard web root no longer redirects to /rollouts #2249

Closed
gdvalle opened this issue Sep 19, 2022 · 1 comment · Fixed by #2252
Closed

Dashboard web root no longer redirects to /rollouts #2249

gdvalle opened this issue Sep 19, 2022 · 1 comment · Fixed by #2252
Labels
bug Something isn't working

Comments

@gdvalle
Copy link

gdvalle commented Sep 19, 2022

Describe the bug
v1.3.0 introduced a behavioral change where the Dashboard UI no longer redirects on the root to /rollouts, and instead displays a 404 not found.

That change seems to have happened here, in the PR to introduce --root-path flag.

To Reproduce

Run argo dashboard on v1.2.2, hit http://<dashboard>, receive a client-side JS redirect to /rollouts.
Run argo dashboard on v1.3.0, hit http://<dashboard>, receive 404 not found from the server.

Expected behavior

Hit http://<dashboard>, receive a client-side JS redirect to /<root-path> if root-path is not on the root. If on the root, no redirection occurs.
OR, have the server itself return a 301/302 to /<root-path>, so there's no javascript requirement.

Version
1.3.0

Logs


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@gdvalle gdvalle added the bug Something isn't working label Sep 19, 2022
@gdvalle
Copy link
Author

gdvalle commented Sep 27, 2022

Thanks, @leoluz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant