Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial provider and prometheus implementation #170

Merged
merged 7 commits into from
Sep 28, 2019
Merged

Conversation

dthomson25
Copy link
Member

I know that is PR will have some merge conflicts with #168, but they should be minor

@codecov
Copy link

codecov bot commented Sep 27, 2019

Codecov Report

Merging #170 into master will increase coverage by 0.54%.
The diff coverage is 98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
+ Coverage   81.91%   82.46%   +0.54%     
==========================================
  Files          29       32       +3     
  Lines        2848     2948     +100     
==========================================
+ Hits         2333     2431      +98     
- Misses        379      380       +1     
- Partials      136      137       +1
Impacted Files Coverage Δ
utils/query/query.go 100% <100%> (ø)
providers/prometheus/prometheus.go 100% <100%> (ø)
utils/evaluate/evaluate.go 80% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea4974c...13f9321. Read the comment docs.

pkg/apis/rollouts/v1alpha1/analysis_types.go Show resolved Hide resolved
providers/provider.go Outdated Show resolved Hide resolved
@dthomson25 dthomson25 marked this pull request as ready for review September 28, 2019 01:17
@dthomson25 dthomson25 merged commit fbb05e1 into master Sep 28, 2019
@dthomson25 dthomson25 deleted the add-provider branch September 28, 2019 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants