Initial analysis controller implementation #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #168 +/- ##
==========================================
- Coverage 82.83% 81.91% -0.93%
==========================================
Files 27 29 +2
Lines 2587 2848 +261
==========================================
+ Hits 2143 2333 +190
- Misses 316 379 +63
- Partials 128 136 +8
Continue to review full report at Codecov.
|
This was referenced Sep 27, 2019
Closed
jessesuen
force-pushed
the
analysis-controller
branch
from
0eb059f to
11f276b
Compare
jessesuen
commented
Sep 27, 2019
jessesuen
commented
Sep 27, 2019
jessesuen
force-pushed
the
analysis-controller
branch
from
11f276b to
f052c77
Compare
dthomson25
reviewed
Sep 27, 2019
| // TODO(jessesuen): may need to tweak this logic | ||
| if metric.Count > 0 && result.Count >= metric.Count { | ||
| var status v1alpha1.AnalysisStatus | ||
| if result.Successful > result.Inconclusive { |
There was a problem hiding this comment.
I'm still a little worried that this is a little "magical" to users. I'm not sure users would expect this to be the behavior
There was a problem hiding this comment.
I agree this may not be expected. I'm open to changing this, thus the TODO.
|
Addressed comments. PTAL. Will leave the TODOs open for improvement later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial AnalysisRun controller logic. Reconcilation does not do anything yet -- need provider interfaces to continue further.