Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modify Experiment collision naming from dot-notation to dash #1646

Merged
merged 2 commits into from
Nov 18, 2021

Conversation

khhirani
Copy link
Contributor

Fix #1631

Signed-off-by: khhirani [email protected]

@harikrongali
Copy link
Contributor

@khhirani can you rebase to latest and rerun e2e & unit tests

@sonarcloud
Copy link

sonarcloud bot commented Nov 15, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
50.0% 50.0% Duplication

@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #1646 (d9c62f8) into master (cac717c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1646   +/-   ##
=======================================
  Coverage   81.94%   81.94%           
=======================================
  Files         115      115           
  Lines       15871    15871           
=======================================
  Hits        13006    13006           
  Misses       2196     2196           
  Partials      669      669           
Impacted Files Coverage Δ
rollout/experiment.go 83.98% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cac717c...d9c62f8. Read the comment docs.

@harikrongali
Copy link
Contributor

@khhirani can you check e2e tests?

@alexmt alexmt merged commit 74e4be4 into argoproj:master Nov 18, 2021
alexmt pushed a commit that referenced this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faulty naming convention for Experiments with collision handling
3 participants