Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faulty naming convention for Experiments with collision handling #1631

Closed
khhirani opened this issue Nov 9, 2021 · 2 comments · Fixed by #1646
Closed

Faulty naming convention for Experiments with collision handling #1631

khhirani opened this issue Nov 9, 2021 · 2 comments · Fixed by #1646
Assignees
Labels
bug Something isn't working cherry-pick/release-1.1
Milestone

Comments

@khhirani
Copy link
Contributor

khhirani commented Nov 9, 2021

We currently use dot-convention to handle collisions in event that there are multiple Experiments with same name and Spec. This is an issue because the name is not DNS compatible and causes problems in the AWS console.

Here is the problematic code:

image

https://github.com/argoproj/argo-rollouts/blob/master/rollout/experiment.go#L208-#L236

@khhirani khhirani added the bug Something isn't working label Nov 9, 2021
@harikrongali
Copy link
Contributor

harikrongali commented Nov 9, 2021

@jessesuen can we name with - (hyphen) instead of . (dot) ? for collision extension?
As service uses experiment name and kubernetes doesn't allow dots in name

@jessesuen
Copy link
Member

Yes that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cherry-pick/release-1.1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants