Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix istio vs reconcile errors #1460

Merged
merged 1 commit into from
Jan 20, 2022
Merged

chore: Fix istio vs reconcile errors #1460

merged 1 commit into from
Jan 20, 2022

Conversation

agrawroh
Copy link
Member

Signed-off-by: Rohit Agrawal [email protected]

This PR fixes a small error in reconcileVirtualService(...) where we try to set the HTTP routes back to the modified VirtualService even if it doesn't exist.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@codecov
Copy link

codecov bot commented Aug 31, 2021 •
edited
Loading

Codecov Report

Merging #1460 (1fdcb96) into master (ac155f1) will increase coverage by 0.00%.
The diff coverage is 70.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1460   +/-   ##
=======================================
  Coverage   81.76%   81.77%           
=======================================
  Files         113      113           
  Lines       15563    15568    +5     
=======================================
+ Hits        12725    12730    +5     
  Misses       2176     2176           
  Partials      662      662
Impacted Files Coverage Δ
rollout/trafficrouting/istio/istio.go 80.97% <40.00%> (+0.03%) ⬆️
utils/ingress/ingress.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe2c68b...1fdcb96. Read the comment docs.

@agrawroh agrawroh requested a review from huikang August 31, 2021 01:21
@agrawroh agrawroh requested a review from huikang September 9, 2021 03:51
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.1% 7.1% Duplication

@harikrongali harikrongali added this to the v1.1 milestone Sep 13, 2021
@harikrongali harikrongali modified the milestones: v1.1, v1.2 Sep 23, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.5% 7.5% Duplication

@agrawroh agrawroh mentioned this pull request Oct 28, 2021
Closed
5 tasks
@jessesuen jessesuen merged commit 4c9adae into argoproj:master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessesuen jessesuen jessesuen approved these changes

@huikang huikang Awaiting requested review from huikang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
5 participants
@agrawroh @huikang @jessesuen @harikrongali @kiranmeduri