fix: Handle minor version with '+' when determining ingress mode (#1529) #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oproj#1529) Signed-off-by: Kiran Meduri <[email protected]>
huikang
reviewed
Oct 27, 2021
Signed-off-by: Kiran Meduri <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Oct 28, 2021
jessesuen
approved these changes
Oct 28, 2021
Codecov Report
@@ Coverage Diff @@
## master #1612 +/- ##
=======================================
Coverage 81.76% 81.76%
=======================================
Files 113 113
Lines 15563 15567 +4
=======================================
+ Hits 12725 12729 +4
Misses 2176 2176
Partials 662 662
Continue to review full report at Codecov.
|
agrawroh
pushed a commit
to agrawroh/argo-rollouts
that referenced
this pull request
Oct 28, 2021
…oproj#1529) (argoproj#1612) Signed-off-by: Kiran Meduri <[email protected]> Signed-off-by: Rohit Agrawal <[email protected]>
agrawroh
pushed a commit
to agrawroh/argo-rollouts
that referenced
this pull request
Oct 28, 2021
…oproj#1529) (argoproj#1612) Signed-off-by: Kiran Meduri <[email protected]> Signed-off-by: Rohit Agrawal <[email protected]>
noam-codefresh
pushed a commit
to codefresh-io/argo-rollouts
that referenced
this pull request
Feb 9, 2022
…oproj#1529) (argoproj#1612) Signed-off-by: Kiran Meduri <[email protected]>
danielm-codefresh
pushed a commit
to codefresh-io/argo-rollouts
that referenced
this pull request
Mar 9, 2022
…oproj#1529) (argoproj#1612) Signed-off-by: Kiran Meduri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
I am noticing errors when running in my cluster with following server version.
Server Version: version.Info{Major:"1", Minor:"21+",...Signed-off-by: Kiran Meduri [email protected]
Checklist:
"fix(controller): Updates such and such. Fixes #1234".