Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: [WIP] Add Graphite metrics provider to address issue #1403 #1404

Closed
wants to merge 20 commits into from
Closed

Feat: [WIP] Add Graphite metrics provider to address issue #1403 #1404

wants to merge 20 commits into from

Conversation

mdb
Copy link
Contributor

@mdb mdb commented Aug 10, 2021

This seeks to address issue #1403 by adding Graphite metrics provider support.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@mdb mdb changed the title [WIP] Add Graphite metrics provider Feat: [WIP] Add Graphite metrics provider to address issue #1403 Aug 10, 2021
mdb and others added 20 commits August 10, 2021 08:22
@mdb
feat: add support for Graphite metrics provider
9ea97c6 
Address issue argoproj#1403 by adding support for a Graphite
metrics provider.

Signed-off-by: Mike Ball <[email protected]>
@mdb
improve testability via API interface and mock
d4b4ba6 
Signed-off-by: Mike Ball <[email protected]>
@mdb
add test for AnalysisPhaseFailed scenario
1a0124b 
Signed-off-by: Mike Ball <[email protected]>
@mdb
add graphite.Provider#Type test
32e96f9 
Signed-off-by: Mike Ball <[email protected]>
@mdb
add graphite.APIClient#Query test
f2d75b0 
Signed-off-by: Mike Ball <[email protected]>
@jessesuen @mdb
chore: github release action was using incorect docker cache (argopro…
a6c2261 
…j#1387)

Signed-off-by: Jesse Suen <[email protected]>
@jessesuen @mdb
chore: release workflow docker build context should use local path an…
7486254 
…d not git context (argoproj#1388)

Signed-off-by: Jesse Suen <[email protected]>
@huikang @mdb
chore: Raname variables, import pkg for clarification (argoproj#1313)
6980947 
Signed-off-by: Hui Kang <[email protected]>
@perenesenko @mdb
feat: configurable and more aggressive cleanup of old AnalysisRuns an…
6b66e9d 
…d Experiments (argoproj#1342)

Signed-off-by: Andrii Perenesenko <[email protected]>
@jessesuen @mdb
fix: retarget blue-green previewService before scaling up preview Rep…
91be160 
…licaSet (argoproj#1368)

Signed-off-by: Jesse Suen <[email protected]>
@dabaooline @mdb
docs: add custom namespace name tips (argoproj#1354)
d07c8a8
@mdb
test invalid Graphite JSON response scenario
e33bd17 
Signed-off-by: Mike Ball <[email protected]>
@mdb
test Graphite error response code scenario
c4aa543 
Signed-off-by: Mike Ball <[email protected]>
@mdb
Graphite provider test exercising evaluation error
3820303 
Signed-off-by: Mike Ball <[email protected]>
@mdb
add provider test exercising Graphite query error
1bc173d 
Signed-off-by: Mike Ball <[email protected]>
@mdb
add Graphite provider #Resume and #Terminate tests
5efba24 
Signed-off-by: Mike Ball <[email protected]>
@mdb
test Graphite Provider #Run measurement error
e5ff86b 
Signed-off-by: Mike Ball <[email protected]>
@mdb
add test exercising invalid query string
971d12b 
Signed-off-by: Mike Ball <[email protected]>
@mdb
test if Graphite returns a data point with 1 item
8513292 
Signed-off-by: Mike Ball <[email protected]>
@mdb
test various Graphite JSON unmarshaling scenarios
f107673 
Signed-off-by: Mike Ball <[email protected]>
@mdb mdb force-pushed the mdb/graphite-metrics-provider branch from b85193c to f107673 Compare August 10, 2021 12:23
@mdb mdb closed this Aug 10, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
3.6% 3.6% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mdb @jessesuen @huikang @perenesenko @dabaooline