feat: configurable and more aggressive cleanup of old AnalysisRuns and Experiments

[perenesenko]

Fixes #1214

Signed-off-by: Andrii Perenesenko [email protected]

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
• The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
• I've signed my commits with DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My builds are green. Try syncing with master if they are not.
• My organization is added to USERS.md.

[codecov]

Codecov Report

Merging #1342 (01b16c6) into master (e3dc6af) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1342      +/-   ##
==========================================
+ Coverage   81.26%   81.33%   +0.07%     
==========================================
  Files         108      108              
  Lines       10033     9955      -78     
==========================================
- Hits         8153     8097      -56     
+ Misses       1319     1306      -13     
+ Partials      561      552       -9     

Impacted Files	Coverage Δ
rollout/analysis.go	80.75% <100.00%> (+0.14%)	⬆️
rollout/experiment.go	85.71% <100.00%> (+0.18%)	⬆️
utils/analysis/filter.go	97.93% <100.00%> (+0.46%)	⬆️
utils/defaults/defaults.go	92.00% <100.00%> (+3.29%)	⬆️
utils/experiment/filter.go	100.00% <100.00%> (ø)
metricproviders/kayenta/kayenta.go	83.11% <0.00%> (-0.85%)	⬇️
rollout/bluegreen.go	70.91% <0.00%> (ø)
utils/replicaset/replicaset.go	89.58% <0.00%> (+0.10%)	⬆️
rollout/replicaset.go	68.42% <0.00%> (+0.89%)	⬆️
utils/replicaset/canary.go	82.56% <0.00%> (+0.91%)	⬆️
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3dc6af...01b16c6. Read the comment docs.

[huikang]

Some minor comments; otherwise it looks good.

[perenesenko]

On standup was decided to reuse the same parameters analysis.* for the Experiments cleaning

[perenesenko]

On a standup also discussed about the changing analysis.failed... => analysis.unsuccessful... and that parameter should includes all 3 phases: Failed, Error, Inconclusive

[huikang]

Just some minor questions. Thanks.

[huikang]

LGTM

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication