Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support https for dex server (#9424) #9881

Closed

Conversation

notfromstatefarm
Copy link
Contributor

Signed-off-by: notfromstatefarm [email protected]

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Closes #9424

This PR enables HTTPS on the Dex server by sharing the certificate used by argo-server.

@notfromstatefarm
Copy link
Contributor Author

I'm leaving this as a draft for now. The more I worked on it, the more I thought: should we really be sharing this certificate? When it's self-signed, it's easy peasy TLS setup. But what if someone provides a certificate that matches their domain? It probably won't be valid for the dex server to use.

Going to investigate giving the dex server its own certificate like repo server. Comments appreciated.

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #9881 (b4dfa27) into master (61f321c) will decrease coverage by 0.00%.
The diff coverage is 35.29%.

@@            Coverage Diff             @@
##           master    #9881      +/-   ##
==========================================
- Coverage   45.73%   45.72%   -0.01%     
==========================================
  Files         227      227              
  Lines       26953    26966      +13     
==========================================
+ Hits        12327    12331       +4     
- Misses      12946    12954       +8     
- Partials     1680     1681       +1     
Impacted Files Coverage Δ
server/server.go 52.83% <0.00%> (-0.35%) ⬇️
util/dex/config.go 84.53% <37.50%> (-4.48%) ⬇️
util/dex/dex.go 88.88% <100.00%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f321c...b4dfa27. Read the comment docs.

@notfromstatefarm
Copy link
Contributor Author

Closing in favor of a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to configure TLS / HTTPS for Dex
1 participant