-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to configure TLS / HTTPS for Dex #9424
Labels
Comments
avidspartan1
changed the title
Ability to configure Dex for TLS
Ability to configure TLS / HTTPS for Dex
May 16, 2022
10 tasks
notfromstatefarm
added a commit
to notfromstatefarm/argo-cd
that referenced
this issue
Jul 5, 2022
Signed-off-by: notfromstatefarm <[email protected]>
10 tasks
notfromstatefarm
added a commit
to notfromstatefarm/argo-cd
that referenced
this issue
Jul 6, 2022
Signed-off-by: notfromstatefarm <[email protected]>
crenshaw-dev
pushed a commit
that referenced
this issue
Jul 13, 2022
* feat: add HTTPS support to dex server (#9424) Signed-off-by: notfromstatefarm <[email protected]> * refactor transports, add v2.5 to docs, other small nits Signed-off-by: notfromstatefarm <[email protected]> * use OIDCTLSConfig in session manager Signed-off-by: notfromstatefarm <[email protected]> * update tls to use os instead of ioutil (but really this is just me trying to get CICD to work) Signed-off-by: notfromstatefarm <[email protected]> * cleanup and nits Signed-off-by: notfromstatefarm <[email protected]> * fix tests after merge Signed-off-by: notfromstatefarm <[email protected]> * fix tests Signed-off-by: notfromstatefarm <[email protected]> * nit Signed-off-by: notfromstatefarm <[email protected]>
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
I would like to configure the bundled Dex deployment to serve over HTTPS instead of HTTP. Currently, HTTP is hard-coded in the ArgoCD wrapper for launching Dex.
Motivation
Encrypting all traffic between pods is a security requirement for me, and likely is for many others. Being able to configure this within ArgoCD (via the ArgoCD Helm chart) instead of having to maintain my own separate Dex Helm release is ideal; one less maintenance burden if it's supported by ArgoCD natively.
Proposal
Similar to how other keys in the Dex config are handled, particularly the
web
key should be checked to see if a value was given for it in the Dex config settings. My best guess is that this would be handled inutil/dex/config.go
: https://github.com/argoproj/argo-cd/blob/master/util/dex/config.go#L29-L31The code currently looks like:
I think it should look something like this:
Take the above with a grain of salt; I'm not very familiar with Go. 😄
The point is to only set
web
if we didn't already find it in the Dex settings; this would allow a user like me to put the following in the Dex config:That definition of
web
would then be added to the generated/tmp/dex.yaml
that the Dex pod then serves.The text was updated successfully, but these errors were encountered: