fix: Helm OCI repositories with custom CAs

[jannfis]

OCI repository URLs are specified without https:// protocol and use either no protocol or oci:// as protocol.

This prevented the use of custom CA certificates to be used with OCI repositories.

This PR fixes that.

Signed-off-by: jannfis [email protected]

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

[codecov]

Codecov Report

Merging #8508 (171fb1f) into master (5c2391f) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master    #8508      +/-   ##
==========================================
- Coverage   45.19%   45.18%   -0.02%     
==========================================
  Files         214      214              
  Lines       25398    25410      +12     
==========================================
+ Hits        11479    11481       +2     
- Misses      12302    12312      +10     
  Partials     1617     1617              

Impacted Files	Coverage Δ
util/cert/cert.go	82.40% <46.15%> (-2.35%)	⬇️
pkg/apis/application/v1alpha1/repository_types.go	69.13% <75.00%> (+8.60%)	⬆️
applicationset/services/scm_provider/github.go	63.52% <0.00%> (-17.65%)	⬇️
applicationset/services/scm_provider/utils.go	88.50% <0.00%> (+4.59%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c2391f...171fb1f. Read the comment docs.

[crenshaw-dev]

Nitpick. Otherwise lgtm. :-)

[crenshaw-dev]

panic might be a little heavy-handed. Can we use require.NoError instead?

[jannfis]

I think we should make a differentiation between the actual code path tested (use assert and require), and unrelated, only test-specific prerequisites failing. This is why I used panic, so that we have a clear separation between a test failing because the code is bad, or a test failing because a test pre-requisite is failing.

[crenshaw-dev]

Interesting, I'd always thought of require as being designed for prereqs. But panic seems reasonable for that as well.

Aside: there's a t.TempDir() that handles failures and cleanup for you. But that can wait for a different PR.

[rishabh625]

@crenshaw-dev : can u plz re review?

[mmerickel]

It sounds like this fixes #7234?

[umutsahin]

Hi @jannfis @crenshaw-dev,
When repo url is like registry.example.com:5000 both parsedURL.Host and parsedURL.Path are empty on the parsed URL.
Because of this certificate is not being loaded.

level=warning msg="Could not get hostname for repository 'registry.example.com:5000'"