OCI runtime exec failed: exec failed: unable to start container process: exec: "bash": executable file not found in $PATH: unknown

[mvpwar]

Terminal exec(v2.4.0-rc5) only support the docker image which entrypoint is "bash", like nginx. Could "sh" entrypoint (is widely used) be supported by stable version in the future? THX!

Terminal error messages:
OCI runtime exec failed: exec failed: unable to start container process: exec: "bash": executable file not found in $PATH: unknown

F12:
WebSocket is already in CLOSING or CLOSED state

[ohauer]

definitive vote for this!

[ohauer]

Not sure if this is the right code place where I found the reference, but it seems "sh" is already defined as validShell.
https://github.com/argoproj/argo-cd/blob/master/server/application/terminal.go#L219
Perhaps it helps most containers to change the order.

[crenshaw-dev]

Yeah, sh should already be supported. Maybe there's an issue in the logic that tries multiple shells.

[ohauer]

Reading the comment on line 255 from terminal.go (L225: // FIXME: if the first shell fails then the first keyboard event is lost) it looks like a known issue, that's why I suggested to change the order.
On most systems where bash is available sh is also available eighter as real sh or as link to bash

[crenshaw-dev]

Yeah, I'm not sure what "the first keyboard event is lost" means, but I don't think it was expected to prevent the terminal from working entirely.

[m-yosefpor]

I think changing the order is not a good solution, as many images provide both sh and bash, but colors, auto-completion, etc is working only with bash, and not sh. So the preference should be with bash if both are provided in an image. I think the logic of trying other terminals should be fixed, so images with only sh can work as well. We have only sh for many of our images, and this useful terminal feature is not usable yet for us without this.

[m-yosefpor]

This is the argocd server error message:

time="2022-06-20T11:28:12Z" level=info msg="terminal session starting" application=sth cluster=sth container=sth namespace=sth podName=sth-6db685f798-gr7ll userName=mohammad.yosefpor
E0620 11:28:12.808320       1 v2.go:105] EOF
time="2022-06-20T11:28:25Z" level=error msg="read message err: websocket: unexpected reserved bits 0x30"
E0620 11:28:25.602831       1 v2.go:105] websocket: unexpected reserved bits 0x30
time="2022-06-20T11:28:25Z" level=error msg="write message err: websocket: close sent"
E0620 11:28:25.625220       1 v2.go:151] websocket: close sent

Also it seems the session starts with sh, as I can see login, but the websocket is closed, so I can't type anything:

[pf2rich]

This problem can be reproduced by starting the pod with an alpine or busybox image.

[pf2rich]

websocks auto input some string for alpine image

[m-yosefpor]

all the following 3 issues are the same:

• ArgoCD v.2.4.0 Terminal read message err: websocket: unexpected reserved bits 0x70 #9643
• Problem with Terminal and linux shell different from bash #9641
• OCI runtime exec failed: exec failed: unable to start container process: exec: "bash": executable file not found in $PATH: unknown #9605

I think we can follow in one thread.