fix: installing packr for arm is no longer working #5904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Go 1.11, "go get" uses the modules system. This changes the location the package is downloaded. Additionally, "go get -u" does more work than required; changing this to "go get -d" speeds up the process. Finally, since Go 1.13 "go get" can also check out tags directly, avoiding an additional checkout. Signed-off-by: Patric Stout <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #5904 +/- ##
=======================================
Coverage 40.89% 40.89%
=======================================
Files 147 147
Lines 19633 19633
=======================================
Hits 8028 8028
Misses 10500 10500
Partials 1105 1105 Continue to review full report at Codecov.
|
alinbalutoiu
approved these changes
Mar 30, 2021
There was a problem hiding this comment.
Looks good to me.
Also tested it here (note that the failure is due to ksonnet and not packr).
alinbalutoiu
pushed a commit
to alinbalutoiu/argo-cd
that referenced
this pull request
Apr 9, 2021
Since Go 1.11, "go get" uses the modules system. This changes the location the package is downloaded. Additionally, "go get -u" does more work than required; changing this to "go get -d" speeds up the process. Finally, since Go 1.13 "go get" can also check out tags directly, avoiding an additional checkout. Signed-off-by: Patric Stout <[email protected]>
shubhamagarwal19
pushed a commit
to shubhamagarwal19/argo-cd
that referenced
this pull request
Apr 15, 2021
Since Go 1.11, "go get" uses the modules system. This changes the location the package is downloaded. Additionally, "go get -u" does more work than required; changing this to "go get -d" speeds up the process. Finally, since Go 1.13 "go get" can also check out tags directly, avoiding an additional checkout. Signed-off-by: Patric Stout <[email protected]>
kshamajain99
pushed a commit
to kshamajain99/argo-cd
that referenced
this pull request
Apr 16, 2021
Since Go 1.11, "go get" uses the modules system. This changes the location the package is downloaded. Additionally, "go get -u" does more work than required; changing this to "go get -d" speeds up the process. Finally, since Go 1.13 "go get" can also check out tags directly, avoiding an additional checkout. Signed-off-by: Patric Stout <[email protected]>
alinbalutoiu
pushed a commit
to alinbalutoiu/argo-cd
that referenced
this pull request
May 24, 2021
Since Go 1.11, "go get" uses the modules system. This changes the location the package is downloaded. Additionally, "go get -u" does more work than required; changing this to "go get -d" speeds up the process. Finally, since Go 1.13 "go get" can also check out tags directly, avoiding an additional checkout. Signed-off-by: Patric Stout <[email protected]>
alinbalutoiu
pushed a commit
to alinbalutoiu/argo-cd
that referenced
this pull request
May 31, 2021
Since Go 1.11, "go get" uses the modules system. This changes the location the package is downloaded. Additionally, "go get -u" does more work than required; changing this to "go get -d" speeds up the process. Finally, since Go 1.13 "go get" can also check out tags directly, avoiding an additional checkout. Signed-off-by: Patric Stout <[email protected]>
alinbalutoiu
pushed a commit
to alinbalutoiu/argo-cd
that referenced
this pull request
Aug 8, 2021
Since Go 1.11, "go get" uses the modules system. This changes the location the package is downloaded. Additionally, "go get -u" does more work than required; changing this to "go get -d" speeds up the process. Finally, since Go 1.13 "go get" can also check out tags directly, avoiding an additional checkout. Signed-off-by: Patric Stout <[email protected]>
alinbalutoiu
pushed a commit
to alinbalutoiu/argo-cd
that referenced
this pull request
Aug 8, 2021
Since Go 1.11, "go get" uses the modules system. This changes the location the package is downloaded. Additionally, "go get -u" does more work than required; changing this to "go get -d" speeds up the process. Finally, since Go 1.13 "go get" can also check out tags directly, avoiding an additional checkout. Signed-off-by: Patric Stout <[email protected]>
alinbalutoiu
pushed a commit
to alinbalutoiu/argo-cd
that referenced
this pull request
Aug 9, 2021
Since Go 1.11, "go get" uses the modules system. This changes the location the package is downloaded. Additionally, "go get -u" does more work than required; changing this to "go get -d" speeds up the process. Finally, since Go 1.13 "go get" can also check out tags directly, avoiding an additional checkout. Signed-off-by: Patric Stout <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ksonnethas a similar issue, butksonnetcan no longer be compiled for arm. See #5271 (comment) for more details on that. So I left that out of this PR, as patching something that is still broken after that, felt not useful to me :)Note: this is the first time ever I did anything with go, so .. be a bit mindful of that while looking at this change :)
Checklist:
I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.Optional. My organization is added to USERS.md.