Skip to content

Commit

Permalink
fix: installing packr for arm is no longer working (argoproj#5904)
Browse files Browse the repository at this point in the history
Since Go 1.11, "go get" uses the modules system. This changes
the location the package is downloaded.

Additionally, "go get -u" does more work than required; changing
this to "go get -d" speeds up the process.

Finally, since Go 1.13 "go get" can also check out tags directly,
avoiding an additional checkout.

Signed-off-by: Patric Stout <[email protected]>
  • Loading branch information
TrueBrain authored and alinbalutoiu committed Aug 8, 2021
1 parent 4c94d88 commit e59b573
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions hack/installers/install-packr-linux.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,8 @@ set -eux -o pipefail
PACKR_VERSION=${packr_version}
case $ARCHITECTURE in
arm|arm64)
# Clone the repository in $GOPATH/src/github.com/gobuffalo/packr
go get -u github.com/gobuffalo/packr
cd $GOPATH/src/github.com/gobuffalo/packr && git checkout tags/v$PACKR_VERSION
cd $GOPATH/src/github.com/gobuffalo/packr && CGO_ENABLED=0 make install
go get -d github.com/gobuffalo/packr@v$PACKR_VERSION
cd $GOPATH/pkg/mod/github.com/gobuffalo/packr@v$PACKR_VERSION && CGO_ENABLED=0 make install
mv $GOPATH/bin/packr $BIN/packr
;;
*)
Expand Down

0 comments on commit e59b573

Please sign in to comment.