Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: helm repo add with flag --insecure-skip-server-verification. #3113 #3420

Merged

Conversation

mayzhang2000
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Optional. My organization is added to USERS.md.
  • I've signed the CLA and my build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #3420 into master will increase coverage by 0.21%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3420      +/-   ##
==========================================
+ Coverage   42.87%   43.09%   +0.21%     
==========================================
  Files         179      179              
  Lines       19899    19800      -99     
  Branches      272      272              
==========================================
  Hits         8532     8532              
+ Misses      10380    10281      -99     
  Partials      987      987              
Impacted Files Coverage Δ
pkg/apis/application/v1alpha1/types.go 61.99% <0.00%> (-0.08%) ⬇️
util/helm/client.go 57.37% <100.00%> (ø)
cmd/argocd/commands/projectwindows.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dbc330...c285556. Read the comment docs.

@mayzhang2000 mayzhang2000 changed the title fix: helm repo add with flag --insecure-skip-server-verification fix: helm repo add with flag --insecure-skip-server-verification. #3113 Apr 15, 2020
@mayzhang2000 mayzhang2000 merged commit 6ffd34d into argoproj:master Apr 15, 2020
@mayzhang2000
Copy link
Contributor Author

close #3113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants