Enhancement proposal : Helm repo add to support --insecure-skip-verify

[pramod0310]

Summary

Adding helm repo does not support insecure options, as supported while adding git repository.

Motivation

Many of the self-hosted helm repositories like harbor etc would be using self-signed certs. It would be a helpful option.

Proposal

The addition of helm repo should also support the insecure-skip-verify option to skip cert verification.

[alexmt]

This is already supported in CLI: argocd ... --insecure-skip-server-verification

The checkbox is missing in UI.

[pramod0310]

@alexmt I tried using --insecure-skip-server-verification for helm charts but does not have any effect only for git it works fine.

[thirdeyenick]

This is because the insecure option is not passed to the Helm client here. It is only passed if the type of the repo is 'git'.

[alexmt]

PR #3420 partially addresses this issue. However, helm CLI itself does not have --insecure flag. So above PR will allow adding repository but it still will be impossible to use charts from the repo (helm repo add will fail) .

The --insecure-skip-tls-verify flag was added to helm last month but still not released (checked both helm v2.16.6 and v3.1.2).

Lets keep ticket open and wait for helm release.

[alexmt]

@mayzhang2000 lets keep it open until we upgrade to the helm 3.20 which adds --insecure-skip-tls-verify flag support. The helm release was published last week so we can work on it now: https://github.com/helm/helm/releases/tag/v3.2.0