Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't disable buttons for multi-source apps #20446

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix: don't disable buttons for multi-source apps #20446

merged 1 commit into from
Oct 18, 2024

Conversation

blakepettersson
Copy link
Member

With #20381 multi-source apps were not taken into account 🤦

Fixes #20445.

Cherry-pick for 2.12 - 2.13.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@blakepettersson
fix: don't disable buttons for multi-source apps
9b0899a 
With argoproj#20381 multi-source apps were not taken into account 🤦

Fixes argoproj#20445.

Signed-off-by: Blake Pettersson <[email protected]>
@blakepettersson blakepettersson requested a review from a team as a code owner October 18, 2024 11:59
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Oct 18, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

nitishfy
nitishfy approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blakepettersson blakepettersson merged commit 76104da into argoproj:master Oct 18, 2024
23 checks passed
@blakepettersson blakepettersson deleted the fix/multi-source-reenable-buttons branch October 18, 2024 13:17
@blakepettersson
Copy link
Member Author

/cherry-pick release-2.13

@blakepettersson
Copy link
Member Author

/cherry-pick release-2.12

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Oct 18, 2024
@blakepettersson
fix: don't disable buttons for multi-source apps (#20446)
be24aff 
With #20381 multi-source apps were not taken into account 🤦

Fixes #20445.

Signed-off-by: Blake Pettersson <[email protected]>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Oct 18, 2024
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Oct 18, 2024
@blakepettersson
fix: don't disable buttons for multi-source apps (#20446)
5bdc349 
With #20381 multi-source apps were not taken into account 🤦

Fixes #20445.

Signed-off-by: Blake Pettersson <[email protected]>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Oct 18, 2024
Merged
crenshaw-dev pushed a commit that referenced this pull request Oct 18, 2024
@gcp-cherry-pick-bot @blakepettersson
fix: don't disable buttons for multi-source apps (#20446) (#20448)
358930b 
With #20381 multi-source apps were not taken into account 🤦

Fixes #20445.

Signed-off-by: Blake Pettersson <[email protected]>
Co-authored-by: Blake Pettersson <[email protected]>
crenshaw-dev pushed a commit that referenced this pull request Oct 18, 2024
@gcp-cherry-pick-bot @blakepettersson
fix: don't disable buttons for multi-source apps (#20446) (#20447)
2076b4f 
With #20381 multi-source apps were not taken into account 🤦

Fixes #20445.

Signed-off-by: Blake Pettersson <[email protected]>
Co-authored-by: Blake Pettersson <[email protected]>
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
@blakepettersson @adriananeci
fix: don't disable buttons for multi-source apps (argoproj#20446)
a50dbf7 
With argoproj#20381 multi-source apps were not taken into account 🤦

Fixes argoproj#20445.

Signed-off-by: Blake Pettersson <[email protected]>
Signed-off-by: Adrian Aneci <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitishfy nitishfy nitishfy approved these changes

@gdsoumya gdsoumya gdsoumya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"SYNC" and "DETAILS" buttons disabled on UI for multi source applications
3 participants
@blakepettersson @gdsoumya @nitishfy