Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"SYNC" and "DETAILS" buttons disabled on UI for multi source applications #20445

Closed
3 tasks done
MairaTariq16 opened this issue Oct 18, 2024 · 3 comments · Fixed by #20446
Closed
3 tasks done

"SYNC" and "DETAILS" buttons disabled on UI for multi source applications #20445

MairaTariq16 opened this issue Oct 18, 2024 · 3 comments · Fixed by #20446
Assignees
@blakepettersson
Labels
bug Something isn't working

Comments

@MairaTariq16
Copy link

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug
"SYNC" and "DETAILS" disabled for applications which have spec.sources instead of spec.source

To Reproduce

  1. Create an application with spec.sources instead of spec.source
  2. ArgoCD UI shows grey-out (disabled) buttons for "SYNC" and "DETAILS"

Expected behavior
These buttons should not be disabled

Screenshots
Screenshot 2024-10-18 at 3 12 13 PM

Version
argocd: v2.12.5+85be9a4
BuildDate: 2024-10-17T20:46:21Z
GitCommit: 85be9a4
GitTreeState: clean
GoVersion: go1.22.4
Compiler: gc
Platform: linux/amd64
@MairaTariq16 MairaTariq16 added the bug Something isn't working label Oct 18, 2024
@blakepettersson blakepettersson self-assigned this Oct 18, 2024
blakepettersson added a commit to blakepettersson/argo-cd that referenced this issue Oct 18, 2024
@blakepettersson
fix: don't disable buttons for multi-source apps
9b0899a 
With argoproj#20381 multi-source apps were not taken into account 🤦

Fixes argoproj#20445.

Signed-off-by: Blake Pettersson <[email protected]>
@blakepettersson blakepettersson mentioned this issue Oct 18, 2024
Merged
14 tasks
gcp-cherry-pick-bot bot pushed a commit that referenced this issue Oct 18, 2024
@blakepettersson
fix: don't disable buttons for multi-source apps (#20446)
be24aff 
With #20381 multi-source apps were not taken into account 🤦

Fixes #20445.

Signed-off-by: Blake Pettersson <[email protected]>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this issue Oct 18, 2024
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this issue Oct 18, 2024
@blakepettersson
fix: don't disable buttons for multi-source apps (#20446)
5bdc349 
With #20381 multi-source apps were not taken into account 🤦

Fixes #20445.

Signed-off-by: Blake Pettersson <[email protected]>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this issue Oct 18, 2024
Merged
crenshaw-dev pushed a commit that referenced this issue Oct 18, 2024
@gcp-cherry-pick-bot @blakepettersson
fix: don't disable buttons for multi-source apps (#20446) (#20448)
358930b 
With #20381 multi-source apps were not taken into account 🤦

Fixes #20445.

Signed-off-by: Blake Pettersson <[email protected]>
Co-authored-by: Blake Pettersson <[email protected]>
crenshaw-dev pushed a commit that referenced this issue Oct 18, 2024
@gcp-cherry-pick-bot @blakepettersson
fix: don't disable buttons for multi-source apps (#20446) (#20447)
2076b4f 
With #20381 multi-source apps were not taken into account 🤦

Fixes #20445.

Signed-off-by: Blake Pettersson <[email protected]>
Co-authored-by: Blake Pettersson <[email protected]>
@YonierGomez
Copy link

I have the same problem, how to solve it?

@blakepettersson
Copy link
Member

There is none apart from downgrading to 2.12.4, sorry about that 😞 There'll be a 2.12.6 which will have the proper fix.

@crenshaw-dev crenshaw-dev mentioned this issue Oct 18, 2024
Closed
@crenshaw-dev
Copy link
Member

Get it while it's hot! https://github.com/argoproj/argo-cd/releases/tag/v2.12.6

adriananeci pushed a commit to adriananeci/argo-cd that referenced this issue Dec 4, 2024
@blakepettersson @adriananeci
fix: don't disable buttons for multi-source apps (argoproj#20446)
a50dbf7 
With argoproj#20381 multi-source apps were not taken into account 🤦

Fixes argoproj#20445.

Signed-off-by: Blake Pettersson <[email protected]>
Signed-off-by: Adrian Aneci <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blakepettersson blakepettersson

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't disable buttons for multi-source apps blakepettersson/argo-cd
4 participants
@crenshaw-dev @blakepettersson @YonierGomez @MairaTariq16