-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lua actions): add a flag to Include builtin actions with resource overrides #19708
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19708 +/- ##
==========================================
- Coverage 55.84% 55.83% -0.01%
==========================================
Files 320 320
Lines 44316 44329 +13
==========================================
+ Hits 24747 24751 +4
- Misses 17012 17019 +7
- Partials 2557 2559 +2 ☔ View full report in Codecov by Sentry. |
0428eeb
to
fb7525f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments
db3189e
to
820ffe3
Compare
FYI, take a look at #16905 (comment). The merge might be conflicting or result in an undefined behavior if glob are used. |
I don't see the glob is used to determine resource action. |
b704567
to
2a8a6eb
Compare
524c0d0
to
eb59403
Compare
6d6973b
to
a07dee6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: Ashutosh Singh <[email protected]>
Signed-off-by: Ashutosh Singh <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
Signed-off-by: ashutosh16 <[email protected]>
Co-authored-by: Alexandre Gaudreault <[email protected]> Signed-off-by: Ashu <[email protected]>
Co-authored-by: Alexandre Gaudreault <[email protected]> Signed-off-by: Ashu <[email protected]> Update util/lua/lua.go Co-authored-by: Alexandre Gaudreault <[email protected]> Signed-off-by: Ashu <[email protected]>
Co-authored-by: Alexandre Gaudreault <[email protected]> Signed-off-by: Ashu <[email protected]> feat: analysis modal Signed-off-by: ashutosh16 <[email protected]> feat: include prebuilt action with overrides Signed-off-by: ashutosh16 <[email protected]> feat: add flag MergeBuiltinActions to include all actions Signed-off-by: ashutosh16 <[email protected]> feat: add flag MergeBuiltinActions to include all actions Signed-off-by: ashutosh16 <[email protected]> feat: add flag MergeBuiltinActions to include all actions Signed-off-by: ashutosh16 <[email protected]> feat: add flag MergeBuiltinActions to include all actions Signed-off-by: ashutosh16 <[email protected]> Update util/lua/lua.go Co-authored-by: Alexandre Gaudreault <[email protected]> Signed-off-by: Ashu <[email protected]> Update util/lua/lua.go Co-authored-by: Alexandre Gaudreault <[email protected]> Signed-off-by: Ashu <[email protected]> Update util/lua/lua.go Co-authored-by: Alexandre Gaudreault <[email protected]> Signed-off-by: Ashu <[email protected]> feat: add flag MergeBuiltinActions to include all actions Signed-off-by: ashutosh16 <[email protected]> feat: add flag MergeBuiltinActions to include all actions Signed-off-by: ashutosh16 <[email protected]>
a07dee6
to
b43d05b
Compare
fixes #19707
To test:
add the below config to the configmap
Verified the following:
Screen.Recording.2024-09-03.at.14.25.41.mov
Checklist: