Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pre-builtin actions with custom action #19707

Closed
ashutosh16 opened this issue Aug 28, 2024 · 1 comment · Fixed by #19708
Closed

Allow pre-builtin actions with custom action #19707

ashutosh16 opened this issue Aug 28, 2024 · 1 comment · Fixed by #19708
Labels
component:actions Issues related to resource actions. enhancement New feature or request

Comments

@ashutosh16
Copy link
Contributor

Summary

ArgoCD provides a single set of actions, either from resource_customization or from overrides in the ConfigMap. If an ArgoCD operator wants to add any ad-hoc action, it will override the prebuilt actions. This behavior is valid since the override functionality is designed to replace existing actions. However, there are scenarios where a user might want to use both prebuilt actions and custom actions in the ConfigMap.

What change you think needs making.
Add flag in the resource action which when set true on the resources, will add all the actions

Motivation

In ArgoCD, we want to add custom actions to the Rollout object to perform specific tasks. However, we also want to retain the prebuilt actions. Therefore, we need a way to include both the prebuilt actions and the custom actions specified in the overrides.

Please give examples of your use case, e.g. when would you use this.
Rollout actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:actions Issues related to resource actions. enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants
@ashutosh16 @pasha-codefresh and others