Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): metadata.annotations: too long message Improved #17452

Merged
merged 5 commits into from
Apr 1, 2024
Merged

feat(ui): metadata.annotations: too long message Improved #17452

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e06a22
metadata.annotations: too long
surajyadav1108 Mar 8, 2024
138b7a5
Merge branch 'argoproj:master' into metadata.annotations-too-long
surajyadav1108 Mar 12, 2024
c6bfd0c
Merge branch 'argoproj:master' into metadata.annotations-too-long
surajyadav1108 Mar 20, 2024
e5db9b0
Merge branch 'argoproj:master' into metadata.annotations-too-long
surajyadav1108 Mar 23, 2024
00e7e0a
added as a default case
surajyadav1108 Mar 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions util/argo/argo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,12 @@ func AugmentSyncMsg(res common.ResourceSyncResult, apiResourceInfoGetter func()
} else {
res.Message = fmt.Sprintf("The Kubernetes API could not find version %q of %s/%s for requested resource %s/%s. Version %q of %s/%s is installed on the destination cluster.", res.Version, res.ResourceKey.Group, res.ResourceKey.Kind, res.ResourceKey.Namespace, res.ResourceKey.Name, resource.GroupVersionResource.Version, resource.GroupKind.Group, resource.GroupKind.Kind)
}

default:
// Check if the message contains "metadata.annotation: Too long"
if strings.Contains(res.Message, "metadata.annotations: Too long: must have at most 262144 bytes") {
res.Message = fmt.Sprintf("%s \n -Additional Info: This error usually means that you are trying to add a large resource on client side. Consider using Server-side apply or syncing with replace enabled. Note: Syncing with Replace enabled is potentially destructive as it may cause resource deletion and re-creation.", res.Message)
}
}

return res.Message, nil
Expand Down
Loading