Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): metadata.annotations: too long message Improved #17452

Merged
merged 5 commits into from
Apr 1, 2024
Merged

feat(ui): metadata.annotations: too long message Improved #17452

merged 5 commits into from
Apr 1, 2024

Conversation

surajyadav1108
Copy link
Contributor

@surajyadav1108 surajyadav1108 commented Mar 8, 2024 •
edited
Loading

Added in a check for "metadata.annotations: too long" message and added with suggestion

resolves #14516

Before
Screenshot 2024-03-08 115602

After
Screenshot 2024-03-08 135413

Wanted to add a line break between the message and suggestion but as all of the other messages were crowded as well so left it for similarity.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@surajyadav1108 surajyadav1108 requested a review from a team as a code owner March 8, 2024 19:29
@surajyadav1108
Copy link
Contributor Author

hey @ishitasequeira Can you review if it is ok 👀?

ishitasequeira
ishitasequeira approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks @surajyadav1108 !!

@ishitasequeira ishitasequeira merged commit 7deafc4 into argoproj:master Apr 1, 2024
27 checks passed
mkieweg pushed a commit to mkieweg/argo-cd that referenced this pull request Jun 11, 2024
@surajyadav1108 @mkieweg
feat(ui): metadata.annotations: too long message Improved (argoproj#1…
d3ab14c 
…7452)

* metadata.annotations: too long

Signed-off-by: Surajyadav <[email protected]>

* added as a default case

Signed-off-by: Surajyadav <[email protected]>

---------

Signed-off-by: Surajyadav <[email protected]>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@surajyadav1108 @Hariharasuthan99
feat(ui): metadata.annotations: too long message Improved (argoproj#1…
f6347bf 
…7452)

* metadata.annotations: too long

Signed-off-by: Surajyadav <[email protected]>

* added as a default case

Signed-off-by: Surajyadav <[email protected]>

---------

Signed-off-by: Surajyadav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

@pasha-codefresh pasha-codefresh Awaiting requested review from pasha-codefresh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better UI presentation of "metadata.annotations: Too long"
3 participants
@surajyadav1108 @pasha-codefresh @ishitasequeira