Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui):Fixed log horizontal scroll for issue #16411 #16727

Merged
merged 4 commits into from
Jan 5, 2024
Merged

fix(ui):Fixed log horizontal scroll for issue #16411 #16727

merged 4 commits into from
Jan 5, 2024

Conversation

ciiay
Copy link
Contributor

@ciiay ciiay commented Jan 2, 2024 •
edited
Loading

For issue #16411
Signed off by: @ciiay [email protected]
This should be cherry-picked into "Version": "v2.9.1+58b04e5",

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • [] My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Fixed log scroll behavior:

fixed_log_horizontal_scroll.mov

@ciiay ciiay requested a review from a team as a code owner January 2, 2024 16:52
@codecov Codecov
Copy link

codecov bot commented Jan 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d595550) 49.48% compared to head (f35aa77) 49.48%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #16727   +/-   ##
=======================================
  Coverage   49.48%   49.48%           
=======================================
  Files         271      271           
  Lines       47728    47728           
=======================================
  Hits        23620    23620           
  Misses      21773    21773           
  Partials     2335     2335

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ciiay
Copy link
Contributor Author

ciiay commented Jan 3, 2024

Happy New Year @crenshaw-dev , could you please take a look at this PR? Thanks in advance.

alexmt
alexmt approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alexmt alexmt merged commit 1372529 into argoproj:master Jan 5, 2024
25 checks passed
@crenshaw-dev
Copy link
Member

/cherry-pick release-2.9

@crenshaw-dev
Copy link
Member

/cherry-pick release-2.10

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jan 5, 2024
@ciiay
fix(ui):Fixed log horizontal scroll for issue #16411 (#16727)
794965c 
* Fixed log horizontal scroll

Signed-off-by: Yi Cai <[email protected]>

* Updated log line-height

Signed-off-by: Yi Cai <[email protected]>

---------

Signed-off-by: Yi Cai <[email protected]>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jan 5, 2024
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jan 5, 2024
@ciiay
fix(ui):Fixed log horizontal scroll for issue #16411 (#16727)
d0f900a 
* Fixed log horizontal scroll

Signed-off-by: Yi Cai <[email protected]>

* Updated log line-height

Signed-off-by: Yi Cai <[email protected]>

---------

Signed-off-by: Yi Cai <[email protected]>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jan 5, 2024
Merged
crenshaw-dev pushed a commit that referenced this pull request Jan 5, 2024
@gcp-cherry-pick-bot @ciiay
fix(ui):Fixed log horizontal scroll for issue #16411 (#16727) (#16761)
45d4a07 
* Fixed log horizontal scroll



* Updated log line-height



---------

Signed-off-by: Yi Cai <[email protected]>
Co-authored-by: Yi Cai <[email protected]>
crenshaw-dev pushed a commit that referenced this pull request Jan 5, 2024
@gcp-cherry-pick-bot @ciiay
fix(ui):Fixed log horizontal scroll for issue #16411 (#16727) (#16762)
3f18c21 
* Fixed log horizontal scroll



* Updated log line-height



---------

Signed-off-by: Yi Cai <[email protected]>
Co-authored-by: Yi Cai <[email protected]>
ebuildy pushed a commit to ebuildy/argo-cd that referenced this pull request Jan 7, 2024
@ciiay @ebuildy
fix(ui):Fixed log horizontal scroll for issue argoproj#16411 (argopro…
13ac49a 
…j#16727)

* Fixed log horizontal scroll

Signed-off-by: Yi Cai <[email protected]>

* Updated log line-height

Signed-off-by: Yi Cai <[email protected]>

---------

Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: ebuildy <[email protected]>
JulienFuix pushed a commit to JulienFuix/argo-cd that referenced this pull request Feb 6, 2024
@ciiay
fix(ui):Fixed log horizontal scroll for issue argoproj#16411 (argopro…
79778e1 
…j#16727)

* Fixed log horizontal scroll

Signed-off-by: Yi Cai <[email protected]>

* Updated log line-height

Signed-off-by: Yi Cai <[email protected]>

---------

Signed-off-by: Yi Cai <[email protected]>
penglongli pushed a commit to penglongli/argo-cd that referenced this pull request Mar 6, 2024
@ciiay @penglongli
fix(ui):Fixed log horizontal scroll for issue argoproj#16411 (argopro…
9ac9325 
…j#16727)

* Fixed log horizontal scroll

Signed-off-by: Yi Cai <[email protected]>

* Updated log line-height

Signed-off-by: Yi Cai <[email protected]>

---------

Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: penglongli <[email protected]>
lyda pushed a commit to lyda/argo-cd that referenced this pull request Mar 28, 2024
@ciiay @lyda
fix(ui):Fixed log horizontal scroll for issue argoproj#16411 (argopro…
e181780 
…j#16727)

* Fixed log horizontal scroll

Signed-off-by: Yi Cai <[email protected]>

* Updated log line-height

Signed-off-by: Yi Cai <[email protected]>

---------

Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Kevin Lyda <[email protected]>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this pull request Jun 16, 2024
@ciiay @Hariharasuthan99
fix(ui):Fixed log horizontal scroll for issue argoproj#16411 (argopro…
b8c6da7 
…j#16727)

* Fixed log horizontal scroll

Signed-off-by: Yi Cai <[email protected]>

* Updated log line-height

Signed-off-by: Yi Cai <[email protected]>

---------

Signed-off-by: Yi Cai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmt alexmt alexmt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ciiay @crenshaw-dev @alexmt