-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pod logs horizontal scroll is per line instead of all lines #16411
Comments
I took another look at the commit I linked, but it seems more likely that this commit caused the issue; 795f225 |
I can reproduce this in 2.9.1. |
Got it, I will take a look at this issue when I'm back in new year. |
* Fixed log horizontal scroll Signed-off-by: Yi Cai <[email protected]> * Updated log line-height Signed-off-by: Yi Cai <[email protected]> --------- Signed-off-by: Yi Cai <[email protected]>
* Fixed log horizontal scroll Signed-off-by: Yi Cai <[email protected]> * Updated log line-height Signed-off-by: Yi Cai <[email protected]> --------- Signed-off-by: Yi Cai <[email protected]>
* Fixed log horizontal scroll Signed-off-by: Yi Cai <[email protected]> * Updated log line-height Signed-off-by: Yi Cai <[email protected]> --------- Signed-off-by: Yi Cai <[email protected]>
* Fixed log horizontal scroll * Updated log line-height --------- Signed-off-by: Yi Cai <[email protected]> Co-authored-by: Yi Cai <[email protected]>
* Fixed log horizontal scroll * Updated log line-height --------- Signed-off-by: Yi Cai <[email protected]> Co-authored-by: Yi Cai <[email protected]>
…j#16727) * Fixed log horizontal scroll Signed-off-by: Yi Cai <[email protected]> * Updated log line-height Signed-off-by: Yi Cai <[email protected]> --------- Signed-off-by: Yi Cai <[email protected]> Signed-off-by: ebuildy <[email protected]>
I noticed this yesterday myself and found it … unintuitive. Not like a normal log viewer. I’m only commenting to help hint that it’s a real issue. |
Can we get a test for this so it doesn't break again? |
…j#16727) * Fixed log horizontal scroll Signed-off-by: Yi Cai <[email protected]> * Updated log line-height Signed-off-by: Yi Cai <[email protected]> --------- Signed-off-by: Yi Cai <[email protected]>
Yi's PR has merged. |
…j#16727) * Fixed log horizontal scroll Signed-off-by: Yi Cai <[email protected]> * Updated log line-height Signed-off-by: Yi Cai <[email protected]> --------- Signed-off-by: Yi Cai <[email protected]> Signed-off-by: penglongli <[email protected]>
…j#16727) * Fixed log horizontal scroll Signed-off-by: Yi Cai <[email protected]> * Updated log line-height Signed-off-by: Yi Cai <[email protected]> --------- Signed-off-by: Yi Cai <[email protected]> Signed-off-by: Kevin Lyda <[email protected]>
…j#16727) * Fixed log horizontal scroll Signed-off-by: Yi Cai <[email protected]> * Updated log line-height Signed-off-by: Yi Cai <[email protected]> --------- Signed-off-by: Yi Cai <[email protected]>
Checklist:
argocd version
.Describe the bug
Scrolling in the log view of pods/deployments/etc. only scrolls per line, instead of all lines together. This is similar to what happened in #14387.
To Reproduce
Expected behavior
I expect a horizontal scroll bar, and for all logs to scroll simultaneously instead of individually.
Screenshots
Recording.2023-11-20.084540.mp4
Version
Logs
The text was updated successfully, but these errors were encountered: