fix: fixed cli admin dashboard cmd #16430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #16430 +/- ##
==========================================
- Coverage 49.53% 49.53% -0.01%
==========================================
Files 269 269
Lines 47222 47224 +2
==========================================
Hits 23392 23392
- Misses 21530 21532 +2
Partials 2300 2300 ☔ View full report in Codecov by Sentry. |
ishitasequeira
previously requested changes
Nov 22, 2023
There was a problem hiding this comment.
@gdsoumya , the generated code seems to be a mismatch. Can you take a look?
gdsoumya
commented
Nov 23, 2023
| @@ -42,7 +46,7 @@ $ argocd admin dashboard --port 8080 --address 127.0.0.1 | |||
| $ argocd admin dashboard --redis-compress gzip | |||
| `, | |||
| } | |||
| initialize.InitCommand(cmd) | |||
| clientConfig = cli.AddKubectlFlagsToSet(cmd.Flags()) | |||
There was a problem hiding this comment.
Without passing the clientConfig directly from the cmd I was not able to use kubectl like flags to configure the cliebntConfig for eg. -n/--namespace was not working before this change. A similar issue was noticed by another user
Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
|
@ishitasequeira updated docs |
|
Double-checked that most recent v2.8 is not affected, so cherry-picking only into 2.9 |
|
/cherry-pick release-2.9 |
|
Cherry-pick failed with |
13 tasks
alexmt
pushed a commit
to alexmt/argo-cd
that referenced
this pull request
Nov 27, 2023
* fix: fixed cli admin dashboard cmd Signed-off-by: Soumya Ghosh Dastidar <[email protected]> * feat: update docs Signed-off-by: Soumya Ghosh Dastidar <[email protected]> --------- Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
alexmt
added a commit
that referenced
this pull request
Nov 27, 2023
* chore(cli): clarify core mode code (#15800) * chore(cli): clarify core mode code Signed-off-by: Michael Crenshaw <[email protected]> * rename function Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]> * fix: fixed cli admin dashboard cmd (#16430) * fix: fixed cli admin dashboard cmd Signed-off-by: Soumya Ghosh Dastidar <[email protected]> * feat: update docs Signed-off-by: Soumya Ghosh Dastidar <[email protected]> --------- Signed-off-by: Soumya Ghosh Dastidar <[email protected]> * chore(ui): Change testEnvironment from node to jsdom (#16287) Signed-off-by: Rafal Pelczar <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Soumya Ghosh Dastidar <[email protected]> Signed-off-by: Rafal Pelczar <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Co-authored-by: Soumya Ghosh Dastidar <[email protected]> Co-authored-by: Rafal <[email protected]>
vladfr
pushed a commit
to vladfr/argo-cd
that referenced
this pull request
Dec 13, 2023
* fix: fixed cli admin dashboard cmd Signed-off-by: Soumya Ghosh Dastidar <[email protected]> * feat: update docs Signed-off-by: Soumya Ghosh Dastidar <[email protected]> --------- Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
* fix: fixed cli admin dashboard cmd Signed-off-by: Soumya Ghosh Dastidar <[email protected]> * feat: update docs Signed-off-by: Soumya Ghosh Dastidar <[email protected]> --------- Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
lyda
pushed a commit
to lyda/argo-cd
that referenced
this pull request
Mar 28, 2024
* fix: fixed cli admin dashboard cmd Signed-off-by: Soumya Ghosh Dastidar <[email protected]> * feat: update docs Signed-off-by: Soumya Ghosh Dastidar <[email protected]> --------- Signed-off-by: Soumya Ghosh Dastidar <[email protected]> Signed-off-by: Kevin Lyda <[email protected]>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
* fix: fixed cli admin dashboard cmd Signed-off-by: Soumya Ghosh Dastidar <[email protected]> * feat: update docs Signed-off-by: Soumya Ghosh Dastidar <[email protected]> --------- Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16379
Fixes #16323
Logs:
Issues resolved :
argocd admin dashboardcmd--address, --portetc. and also k8s flags like-nChecklist: