-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ui): Change testEnvironment from node to jsdom #16287
Conversation
Signed-off-by: Rafal Pelczar <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16287 +/- ##
=======================================
Coverage 49.51% 49.52%
=======================================
Files 269 269
Lines 46990 46990
=======================================
+ Hits 23269 23272 +3
+ Misses 21437 21435 -2
+ Partials 2284 2283 -1 ☔ View full report in Codecov by Sentry. |
Thanks for this! I was wondering why these tests were failing in CI for my non-UI change.
This was also confusing me. For what it's worth I can reproduce this failure everytime locally if I run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Signed-off-by: Rafal Pelczar <[email protected]> Signed-off-by: jmilic1 <[email protected]>
Signed-off-by: Rafal Pelczar <[email protected]>
* chore(cli): clarify core mode code (#15800) * chore(cli): clarify core mode code Signed-off-by: Michael Crenshaw <[email protected]> * rename function Signed-off-by: Michael Crenshaw <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]> * fix: fixed cli admin dashboard cmd (#16430) * fix: fixed cli admin dashboard cmd Signed-off-by: Soumya Ghosh Dastidar <[email protected]> * feat: update docs Signed-off-by: Soumya Ghosh Dastidar <[email protected]> --------- Signed-off-by: Soumya Ghosh Dastidar <[email protected]> * chore(ui): Change testEnvironment from node to jsdom (#16287) Signed-off-by: Rafal Pelczar <[email protected]> --------- Signed-off-by: Michael Crenshaw <[email protected]> Signed-off-by: Soumya Ghosh Dastidar <[email protected]> Signed-off-by: Rafal Pelczar <[email protected]> Co-authored-by: Michael Crenshaw <[email protected]> Co-authored-by: Soumya Ghosh Dastidar <[email protected]> Co-authored-by: Rafal <[email protected]>
Signed-off-by: Rafal Pelczar <[email protected]>
Signed-off-by: Rafal Pelczar <[email protected]>
Signed-off-by: Rafal Pelczar <[email protected]> Signed-off-by: Kevin Lyda <[email protected]>
Signed-off-by: Rafal Pelczar <[email protected]>
Tests in some PRs failed because the testEnvironment option was set incorrectly. I have no idea why the tests sometimes passed. This change should fix that.
Checklist: